-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bumping pyarrow / pandas #17290
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17290 +/- ##
=======================================
Coverage 77.08% 77.08%
=======================================
Files 1037 1037
Lines 55653 55654 +1
Branches 7607 7607
=======================================
+ Hits 42901 42902 +1
Misses 12502 12502
Partials 250 250
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pyarrow 6.0 is the minimum requirement to use the python 3.10 wheel for pyarrow. I can upgrade easily to pyarrow 6.0 with only a few dependency changes (thereby allow me to run superset with python 3.10):
@craig-rueda Do you see any problems with the above changes? The upgrade block to pyparsing 3.0 was introduced in #11418 by @zhaoyongjie . I suspect that a review and some testing of the time picker feature is required to assess compatibility with pyparsing 3.0.6 |
I think it should be fine. I'll test it out on M1 hardware to be certain in the next day or so. That's the only potential issue I know of. |
FIY, I have been running a local dev set up (no docker, just plain python 3.10 on Arch Linux) without problem with the above changes. I am certainly not claiming to have done any sort of rigorous testing. Let me know if you would like me to open an issue / PR for this dependency update change. |
* Bumping pyarrow / pandas * Appeasing the pylint gods * Adjusting UPDATING.md * Buping testing requirements
SUMMARY
Bumps pandas to
1.3.4
and pyarrow to5.0.0
. Note that6.0.0
is the latest pyarrow, but there are other dependencies with conflicting ranges. Also note that pylint yelled at me about various superfluous "ignores" that I ended up fixing. Hence all the seemingly unrelated changes.