fix: Show sqllab state when deleting databases #17331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17331 +/- ##
==========================================
- Coverage 77.19% 77.06% -0.14%
==========================================
Files 1036 1036
Lines 55696 55729 +33
Branches 7627 7627
==========================================
- Hits 42994 42945 -49
- Misses 12446 12528 +82
Partials 256 256
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hughhhh
changed the title
hughhhh
force-pushed
the
hugh/show-tabstates
branch
3 times, most recently
from
94006e3
to
fc6ac10
Compare
hughhhh
force-pushed
the
hugh/show-tabstates
branch
from
fc6ac10
to
bd3bf6e
Compare
hughhhh
changed the title
betodealmeida
approved these changes
Nov 4, 2021
| @@ -437,10 +439,11 @@ function DatabaseList({ addDangerToast, addSuccessToast }: DatabaseListProps) { | |||
| {databaseCurrentlyDeleting && ( | |||
| <DeleteModal | |||
| description={t( | |||
| 'The database %s is linked to %s charts that appear on %s dashboards. Are you sure you want to continue? Deleting the database will break those objects.', | |||
| 'The database %s is linked to %s charts that appear on %s dashboards and users have %s SQL Lab tabs using this database open. Are you sure you want to continue? Deleting the database will break those objects.', | |||
There was a problem hiding this comment.
It would be nice to skip this message if all the counts are 0, something like:
const message = (
databaseCurrentlyDeleting.chart_count +
databaseCurrentlyDeleting.dashboard_count +
databaseCurrentlyDeleting.sqllab_tab_count) === 0
? 'There are no charts, dashboards or queries associated with this database, it should be safe to delete.'
: 'The database %s is linked to ...';
AAfghahi
pushed a commit
that referenced
this pull request
Jan 10, 2022
* saving * fix ts * update test * update test * log unit * updated test
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Provide more context on the SQL Tab States for any database that is about to be deleted. Before we'd only show charts and dashboards, now we show the number of tab states currently saved in the metastore. These tabs would block database deletion and raise a non informative message after the request.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION