Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add native filter default value e2e #17398

Merged
merged 3 commits into from
Nov 16, 2021

Conversation

jinghua-qa
Copy link
Member

SUMMARY

add native filter default value e2e test: User can check 'Filter has default value

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@superset-github-bot superset-github-bot bot added the preset:QA Preset QA team label Nov 11, 2021
@jinghua-qa jinghua-qa changed the title add native filter default value e2e test test:add native filter default value e2e test Nov 11, 2021
@jinghua-qa jinghua-qa closed this Nov 11, 2021
@jinghua-qa jinghua-qa reopened this Nov 11, 2021
@jinghua-qa jinghua-qa changed the title test:add native filter default value e2e test test:add native filter default value e2e Nov 11, 2021
@jinghua-qa jinghua-qa closed this Nov 11, 2021
@jinghua-qa jinghua-qa reopened this Nov 11, 2021
@jinghua-qa jinghua-qa changed the title test:add native filter default value e2e test: add native filter default value e2e Nov 11, 2021
@jinghua-qa jinghua-qa closed this Nov 11, 2021
@jinghua-qa jinghua-qa reopened this Nov 11, 2021
@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #17398 (6d49f2e) into master (1beda79) will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17398      +/-   ##
==========================================
- Coverage   77.02%   76.91%   -0.12%     
==========================================
  Files        1038     1039       +1     
  Lines       56021    56153     +132     
  Branches     7735     7785      +50     
==========================================
+ Hits        43150    43189      +39     
- Misses      12613    12706      +93     
  Partials      258      258              
Flag Coverage Δ
javascript 71.02% <ø> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ols/DndColumnSelectControl/utils/optionSelector.ts 35.55% <0.00%> (-10.60%) ⬇️
...ols/DndColumnSelectControl/ColumnSelectPopover.tsx 12.96% <0.00%> (-3.17%) ⬇️
...ColumnSelectControl/ColumnSelectPopoverTrigger.tsx 80.95% <0.00%> (-2.39%) ⬇️
...ontrols/DndColumnSelectControl/DndColumnSelect.tsx 45.97% <0.00%> (-1.59%) ⬇️
...ols/FilterControl/AdhocFilterEditPopover/index.jsx 64.91% <0.00%> (-1.19%) ⬇️
.../controls/DndColumnSelectControl/OptionWrapper.tsx 84.74% <0.00%> (-0.71%) ⬇️
...rontend/src/dashboard/containers/DashboardPage.tsx 25.51% <0.00%> (-0.27%) ⬇️
...ols/MetricControl/AdhocMetricEditPopover/index.jsx 86.42% <0.00%> (-0.20%) ⬇️
...nd/src/explore/components/DataTablesPane/index.tsx 85.58% <0.00%> (-0.13%) ⬇️
...nd/src/explore/components/ExploreViewContainer.jsx 2.08% <0.00%> (-0.04%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1beda79...6d49f2e. Read the comment docs.

@geido geido self-requested a review November 11, 2021 17:29
.find(nativeFilters.filtersPanel.filterName)
.click()
.type('country_name');
cy.get('.loading inline-centered css-101mkpk').should('not.exist');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might need to be like the following instead? Also, I would avoid pointing to generated classes like this one if possible css-101mkpk

Suggested change
cy.get('.loading inline-centered css-101mkpk').should('not.exist');
cy.get('.loading .inline-centered .css-101mkpk').should('not.exist');

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think it is not necessary to check the generated classes, remove that line

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@geido geido merged commit 1e2c834 into apache:master Nov 16, 2021
AAfghahi pushed a commit that referenced this pull request Jan 10, 2022
* add native filter default value e2e test

* fix lint

* remove unnecessary check
@mistercrunch mistercrunch added the 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:QA Preset QA team size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants