-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Always use temporal type for dttm columns [ID-2] #17458
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17458 +/- ##
==========================================
- Coverage 76.94% 76.73% -0.22%
==========================================
Files 1042 1042
Lines 56248 56257 +9
Branches 7784 7784
==========================================
- Hits 43282 43168 -114
- Misses 12707 12830 +123
Partials 259 259
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* fix: Always use temporal type for dttm columns * move inference and implement in chart postproc * fix test * fix test case Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
SUMMARY
If a column is marked as
is_dttm
, always return it's generic type asTEMPORAL
. This change fixes a bug in databases like Druid that sometimes return dates as string instead of datetime format.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
coltype
returned for that column in response is equal to 2 - TemporalADDITIONAL INFORMATION
CC @jinghua-qa @junlincc