Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create-admin command in Makefile #17471

Merged
merged 2 commits into from
Nov 18, 2021
Merged

fix: create-admin command in Makefile #17471

merged 2 commits into from
Nov 18, 2021

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Nov 17, 2021

SUMMARY

When a user runs make install the load-examples section would fail if the user didn't create an user with username admin. To fix this I've update the install command to create an admin user by default and added a make admin-user for users who need to create a specific Admin user

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #17471 (fa6005a) into master (3f2129b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17471   +/-   ##
=======================================
  Coverage   76.94%   76.94%           
=======================================
  Files        1042     1042           
  Lines       56312    56312           
  Branches     7793     7793           
=======================================
  Hits        43329    43329           
  Misses      12727    12727           
  Partials      256      256           
Flag Coverage Δ
hive 81.52% <ø> (ø)
javascript 71.03% <ø> (ø)
mysql 81.94% <ø> (ø)
postgres 81.95% <ø> (ø)
presto 81.82% <ø> (ø)
python 82.45% <ø> (ø)
sqlite 81.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f2129b...fa6005a. Read the comment docs.

Copy link

@ryankubin ryankubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Makefile Outdated
--username admin \
--firstname Admin \
--lastname Strator \
--email admin@apache.org \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a real email?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol not sure let me change it

--firstname Admin \
--lastname Strator \
--email admin@superset.io \
--password admin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change the password to "general"
or change all the test fixtures that add an admin user, the password to admin

@hughhhh hughhhh merged commit 7b68002 into master Nov 18, 2021
AAfghahi pushed a commit that referenced this pull request Jan 10, 2022
* update make file

* Update Makefile
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the update-make branch March 26, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants