Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate Fieldset component from jsx to tsx #17474

Merged
merged 3 commits into from
Nov 29, 2021

Conversation

Damans227
Copy link
Contributor

SUMMARY

PR for migrating Fieldset react component from JSX to TSX

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: [TRACKER] Migrate JavaScript files to TypeScript #10004
  • Enhancement (new features, refinement)
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@Damans227
Copy link
Contributor Author

@etr2460 Ptal, thx!

@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #17474 (5e4ace9) into master (3f2129b) will increase coverage by 0.06%.
The diff coverage is 74.20%.

❗ Current head 5e4ace9 differs from pull request most recent head 5624ef2. Consider uploading reports for the commit 5624ef2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17474      +/-   ##
==========================================
+ Coverage   76.94%   77.01%   +0.06%     
==========================================
  Files        1042     1049       +7     
  Lines       56312    56683     +371     
  Branches     7793     7852      +59     
==========================================
+ Hits        43329    43652     +323     
- Misses      12727    12778      +51     
+ Partials      256      253       -3     
Flag Coverage Δ
javascript 71.07% <74.20%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/SqlLab/actions/sqlLab.js 58.69% <0.00%> (ø)
...erset-frontend/src/SqlLab/components/App/index.jsx 56.66% <ø> (ø)
...frontend/src/SqlLab/components/ResultSet/index.tsx 61.48% <ø> (ø)
...c/SqlLab/components/TemplateParamsEditor/index.tsx 88.88% <ø> (ø)
...uperset-frontend/src/components/Menu/MenuRight.tsx 92.30% <ø> (ø)
...rontend/src/components/Select/DeprecatedSelect.tsx 63.63% <ø> (-1.07%) ⬇️
...end/src/components/Select/WindowedSelect/index.tsx 100.00% <ø> (ø)
...t-frontend/src/dashboard/actions/dashboardState.js 28.80% <0.00%> (-0.16%) ⬇️
...t-frontend/src/dashboard/components/SliceAdder.jsx 76.62% <ø> (ø)
...dashboard/components/SliceHeaderControls/index.tsx 75.38% <0.00%> (ø)
... and 142 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f2129b...5624ef2. Read the comment docs.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, add a few type suggestions.

superset-frontend/src/CRUD/Fieldset.tsx Outdated Show resolved Hide resolved
superset-frontend/src/CRUD/Fieldset.tsx Outdated Show resolved Hide resolved
@villebro
Copy link
Member

@Damans227 did you have a chance to see the proposed changes? Would be nice to get this merged soon.

@Damans227
Copy link
Contributor Author

@Damans227 did you have a chance to see the proposed changes? Would be nice to get this merged soon.

Not yet. Apologies for the delay, I will take a look at it today.

@villebro
Copy link
Member

@etr2460 feel free to merge this if all is ok

Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the iteration @Damans227 !

@etr2460 etr2460 merged commit bfba4f1 into apache:master Nov 29, 2021
@Damans227 Damans227 deleted the enhancement/migrate-jsx-to-tsx_5 branch November 29, 2021 22:41
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants