-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate Fieldset component from jsx to tsx #17474
chore: migrate Fieldset component from jsx to tsx #17474
Conversation
@etr2460 Ptal, thx! |
Codecov Report
@@ Coverage Diff @@
## master #17474 +/- ##
==========================================
+ Coverage 76.94% 77.01% +0.06%
==========================================
Files 1042 1049 +7
Lines 56312 56683 +371
Branches 7793 7852 +59
==========================================
+ Hits 43329 43652 +323
- Misses 12727 12778 +51
+ Partials 256 253 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, add a few type suggestions.
@Damans227 did you have a chance to see the proposed changes? Would be nice to get this merged soon. |
Not yet. Apologies for the delay, I will take a look at it today. |
@etr2460 feel free to merge this if all is ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for the iteration @Damans227 !
SUMMARY
PR for migrating
Fieldset
react component from JSX to TSXBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION