-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(de-translation): update German translations (based on master) (#17441) #17478
Conversation
Thanks so much for the contribution @hbruch ! 🇩🇪 Unless nobody else steps up I can give it a quick review (my German is not fluent but I might spot a typo) |
Codecov Report
@@ Coverage Diff @@
## master #17478 +/- ##
==========================================
- Coverage 76.94% 76.75% -0.19%
==========================================
Files 1042 1045 +3
Lines 56312 56430 +118
Branches 7793 7793
==========================================
- Hits 43329 43315 -14
- Misses 12727 12859 +132
Partials 256 256
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@hbruch feel free to remove the draft and WIP label once you feel this is ready for review. |
I re-checked the translations and modified some. Should be ready for review now. |
@villebro just noticed, that |
😱 Great catch! Yes, by all means do open a new PR for that. Let me do a quick review, and if this looks good let's merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ok. So you'll merge this PR, I'll submit a PR adding |
Exactly! I'll merge now, thanks for the quick response! |
SUMMARY
This PR updates the .pot file as described in https://github.com/apache/superset/blob/master/CONTRIBUTING.md#extracting-new-strings-for-translation and updates German translations.
This PR is marked WIP as I want to reread all translations once again .TESTING INSTRUCTIONS
Would be great, if a German speaker could review, at least
ADDITIONAL INFORMATION