Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(de-translation): update German translations (based on master) (#17441) #17478

Merged
merged 6 commits into from
Nov 23, 2021

Conversation

hbruch
Copy link
Contributor

@hbruch hbruch commented Nov 18, 2021

SUMMARY

This PR updates the .pot file as described in https://github.com/apache/superset/blob/master/CONTRIBUTING.md#extracting-new-strings-for-translation and updates German translations.

This PR is marked WIP as I want to reread all translations once again .

TESTING INSTRUCTIONS

Would be great, if a German speaker could review, at least

  • if we agree on important, recurring keywords.
  • to suggest translations for the few remaining fuzzy messages

ADDITIONAL INFORMATION

  • Has associated issue: Fixes German translations missing or wrong #17441
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hbruch hbruch marked this pull request as draft November 18, 2021 11:54
@villebro
Copy link
Member

Thanks so much for the contribution @hbruch ! 🇩🇪 Unless nobody else steps up I can give it a quick review (my German is not fluent but I might spot a typo)

@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #17478 (8d29ffa) into master (56d742f) will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17478      +/-   ##
==========================================
- Coverage   76.94%   76.75%   -0.19%     
==========================================
  Files        1042     1045       +3     
  Lines       56312    56430     +118     
  Branches     7793     7793              
==========================================
- Hits        43329    43315      -14     
- Misses      12727    12859     +132     
  Partials      256      256              
Flag Coverage Δ
hive ?
mysql 81.97% <ø> (+0.03%) ⬆️
postgres 81.98% <ø> (+0.03%) ⬆️
presto ?
python 82.07% <ø> (-0.39%) ⬇️
sqlite 81.66% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 69.49% <0.00%> (-16.99%) ⬇️
superset/db_engine_specs/presto.py 83.50% <0.00%> (-6.87%) ⬇️
superset/views/api.py 67.18% <0.00%> (-4.25%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 86.79% <0.00%> (-1.59%) ⬇️
superset/common/query_context.py 91.03% <0.00%> (-0.82%) ⬇️
superset/models/core.py 89.26% <0.00%> (-0.74%) ⬇️
superset/db_engine_specs/base.py 88.20% <0.00%> (-0.39%) ⬇️
superset/charts/schemas.py 99.65% <0.00%> (-0.35%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56d742f...8d29ffa. Read the comment docs.

@villebro
Copy link
Member

@hbruch feel free to remove the draft and WIP label once you feel this is ready for review.

@hbruch hbruch changed the title (WIP) chore(de-translation): update German translations (based on master) (#17441) chore(de-translation): update German translations (based on master) (#17441) Nov 19, 2021
@hbruch hbruch marked this pull request as ready for review November 19, 2021 16:08
@hbruch
Copy link
Contributor Author

hbruch commented Nov 19, 2021

I re-checked the translations and modified some. Should be ready for review now.

@hbruch
Copy link
Contributor Author

hbruch commented Nov 21, 2021

@villebro just noticed, that *.ts files are not extracted, as the ts suffix is missing in babel.cfg. I'd suggest to open another PR after this one is merged, WDYT?

@villebro
Copy link
Member

@villebro just noticed, that *.ts files are not extracted, as the ts suffix is missing in babel.cfg. I'd suggest to open another PR after this one is merged, WDYT?

😱 Great catch! Yes, by all means do open a new PR for that. Let me do a quick review, and if this looks good let's merge this.

@villebro
Copy link
Member

@hbruch while reviewing your PR I found some broken translation strings that I've fixed in this PR: #17501 If you have the time please feel free to review.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro
Copy link
Member

@hbruch are you ok with me merging this, or do you want to rebase to pull in #17501 ? I'd personally prefer to merge this as-is and then do a follow-up once the ts translation fix is also in place.

@hbruch
Copy link
Contributor Author

hbruch commented Nov 23, 2021

Ok. So you'll merge this PR, I'll submit a PR adding ts and updated pot and afterwards another PR adding the German translations only? Would be fine for me.

@villebro
Copy link
Member

Ok. So you'll merge this PR, I'll submit a PR adding ts and updated pot and afterwards another PR adding the German translations only? Would be fine for me.

Exactly! I'll merge now, thanks for the quick response!

@villebro villebro merged commit 228f936 into apache:master Nov 23, 2021
@hbruch hbruch deleted the de-translation branch November 23, 2021 09:17
AAfghahi pushed a commit that referenced this pull request Jan 10, 2022
…17441) (#17478)

* pybabel extract

* Add and correct de translations

* Revisited German translations

* Few German translation fixes

* Remove empty line at EOF

* Fix some translations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

German translations missing or wrong
2 participants