Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Makefile #17480

Merged
merged 1 commit into from
Nov 18, 2021
Merged

fix: Update Makefile #17480

merged 1 commit into from
Nov 18, 2021

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Nov 18, 2021

SUMMARY

Change makefile to admin password to general per @ofekisr request

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #17480 (3c16c51) into master (7b68002) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17480      +/-   ##
==========================================
- Coverage   76.95%   76.88%   -0.08%     
==========================================
  Files        1043     1043              
  Lines       56368    56368              
  Branches     7793     7793              
==========================================
- Hits        43380    43336      -44     
- Misses      12732    12776      +44     
  Partials      256      256              
Flag Coverage Δ
hive 81.53% <ø> (ø)
javascript 71.03% <ø> (ø)
mysql 81.96% <ø> (ø)
postgres 81.97% <ø> (ø)
presto ?
python 82.32% <ø> (-0.16%) ⬇️
sqlite 81.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/presto.py 84.30% <0.00%> (-6.07%) ⬇️
superset/connectors/sqla/models.py 87.02% <0.00%> (-1.36%) ⬇️
superset/models/core.py 89.26% <0.00%> (-0.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b68002...3c16c51. Read the comment docs.

@hughhhh hughhhh changed the title Update Makefile fix: Update Makefile Nov 18, 2021
@hughhhh hughhhh merged commit fb1bc6c into master Nov 18, 2021
AAfghahi pushed a commit that referenced this pull request Jan 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the hughhhh-patch-2 branch March 26, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants