Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update node version in nvmrc to v16 #17492

Merged
merged 1 commit into from
Nov 23, 2021
Merged

chore: update node version in nvmrc to v16 #17492

merged 1 commit into from
Nov 23, 2021

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Nov 20, 2021

SUMMARY

#16809 updated node version but it didn't update nvmrc. It's better to keep them consistent.

cc @villebro

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

#16809 updated node version but it didn't update nvmrc.
@ktmud ktmud changed the title chore: update node version in nvmrc chore: update node version in nvmrc to v16 Nov 20, 2021
@codecov
Copy link

codecov bot commented Nov 20, 2021

Codecov Report

Merging #17492 (6a6b4bd) into master (69c3cc7) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17492   +/-   ##
=======================================
  Coverage   76.97%   76.97%           
=======================================
  Files        1043     1043           
  Lines       56381    56381           
  Branches     7798     7798           
=======================================
+ Hits        43400    43402    +2     
+ Misses      12725    12723    -2     
  Partials      256      256           
Flag Coverage Δ
hive 81.56% <ø> (ø)
javascript 71.05% <ø> (ø)
mysql 81.98% <ø> (ø)
postgres 81.99% <ø> (ø)
presto 81.86% <ø> (+<0.01%) ⬆️
python 82.49% <ø> (+<0.01%) ⬆️
sqlite 81.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/presto.py 90.37% <0.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69c3cc7...6a6b4bd. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching 👍

@villebro
Copy link
Member

Merging to get this into master

@villebro villebro merged commit 27e7fb3 into master Nov 23, 2021
AAfghahi pushed a commit that referenced this pull request Jan 10, 2022
#16809 updated node version but it didn't update nvmrc.
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the ktmud-patch-2 branch March 26, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants