-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump major on Pillow, optional dependency #17521
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17521 +/- ##
==========================================
- Coverage 76.92% 76.78% -0.14%
==========================================
Files 1048 1048
Lines 56514 56509 -5
Branches 7805 7805
==========================================
- Hits 43474 43392 -82
- Misses 12786 12863 +77
Partials 254 254
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a non-blocking consideration
setup.py
Outdated
"thumbnails": ["Pillow>=7.0.0, <8.0.0"], | ||
"thumbnails": ["Pillow>=8.2.0, <9.0.0"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears we're already pinning to >=8.3.1 in the development deps - perhaps we could use the same version here and potentially consider bumping to 8.3.2 which addresses CVE-2021-23437?
superset/requirements/development.in
Line 21 in 0f3b630
pillow>=8.3.1,<9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, made the change
This reverts commit ce640ac.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* chore: bump major on Pillow, optional dependency * bump to 8.3.2 * Revert "bump to 8.3.2" This reverts commit ce640ac. * bump to 8.3.2 now the right way
SUMMARY
Bump Pillow optional dependency (used for taking web screenshots) to address several security vulnerabilities: https://www.cvedetails.com/product/27460/Python-Pillow.html?vendor_id=10210
TESTING INSTRUCTIONS
Make sure we are still able to generate thumbnails and reports with charts and dashboards screenshots
ADDITIONAL INFORMATION