Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(monorepo): move superset-ui to superset(stage 2) #17552

Merged
merged 21 commits into from
Nov 30, 2021

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Nov 25, 2021

SUMMARY

This PR implement SIP-58, move superset-ui to this repo. NOTICE: Please merge relocation-PR before merging this PR.

  1. Move packages, plugins, scripts directories into superset_frontend
  2. All remaining files are saved in temporary_superset_ui
  3. add packages/* and plugins/* to lerna packages
  4. refactor superset-generator unit test
  5. add babel-extract.sh. packages and plugins is appended in babel.cfg

image


To ensure that every PR passes the CI, the monorepo-related PR is split into multiple stages.

  1. refactor(monorepo): stage 1 #17427
  2. refactor(monorepo): relocate superset-ui #17445
  3. refactor(monorepo): move superset-ui to superset(stage 2) #17437 (this PR)

@zhaoyongjie zhaoyongjie changed the title Monorepo stage 2 refactor(monorepo): move superset-ui to superset(stage 2) Nov 25, 2021
@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #17552 (fcbcca6) into master (6604a6a) will decrease coverage by 8.35%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17552      +/-   ##
==========================================
- Coverage   76.94%   68.59%   -8.36%     
==========================================
  Files        1049     1588     +539     
  Lines       56672    64931    +8259     
  Branches     7849     6961     -888     
==========================================
+ Hits        43609    44542     +933     
- Misses      12810    18499    +5689     
- Partials      253     1890    +1637     
Flag Coverage Δ
hive 81.61% <ø> (ø)
javascript 57.08% <50.00%> (-14.01%) ⬇️
mysql 82.02% <ø> (ø)
postgres 82.03% <ø> (ø)
presto 81.90% <ø> (?)
python 82.52% <ø> (+0.14%) ⬆️
sqlite 81.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntrols/src/components/CertifiedIconWithTooltip.tsx 88.88% <ø> (ø)
...-ui-chart-controls/src/components/ColumnOption.tsx 91.30% <ø> (ø)
...-chart-controls/src/components/ColumnTypeLabel.tsx 90.00% <ø> (ø)
...ols/src/components/ControlForm/ControlFormItem.tsx 24.24% <ø> (ø)
...t-controls/src/components/ControlForm/controls.tsx 100.00% <ø> (ø)
...hart-controls/src/components/ControlForm/index.tsx 14.28% <ø> (ø)
...ui-chart-controls/src/components/ControlHeader.tsx 19.23% <ø> (ø)
...controls/src/components/InfoTooltipWithTrigger.tsx 100.00% <ø> (ø)
...-ui-chart-controls/src/components/MetricOption.tsx 95.83% <ø> (ø)
...perset-ui-chart-controls/src/components/Select.tsx 14.28% <ø> (ø)
... and 1285 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6604a6a...fcbcca6. Read the comment docs.

@zhaoyongjie zhaoyongjie force-pushed the monorepo_stage_2 branch 5 times, most recently from cf6acbf to 44cbf80 Compare November 26, 2021 07:45
@zhaoyongjie zhaoyongjie added risk:many-files Change has too many files risk:refactor High risk as it involves large refactoring work risk:superset-ui hold! On hold hold:testing! On hold for testing labels Nov 26, 2021
@villebro villebro force-pushed the monorepo_stage_2 branch 2 times, most recently from 342d5b0 to 508b9a0 Compare November 26, 2021 11:53
edit .codecov.yml
fix refactor genertor lint error
update jest.config.js

allow superset-generator

temporarily  disallow generator unit test

temporarily remove test dir in plugins

ignore superet-ui-demo

fix dir

try to increase code coverage

prettier

disable generator

update jest

updates

root jest remove generator

add comments

update jest config
add comments
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments. In general I find this works very well, amazing work! 🎉 There will inevitably be some todos that will require follow-up PRs, but I think this is already a big improvement over the current development workflow, so feeling inclined to approve this to unblock plugin development.

superset/translations/babel.cfg Outdated Show resolved Hide resolved
@@ -14,6 +15,17 @@ coverage:
# project coverage decrease:
target: auto
threshold: 0%
core-packages-ts:
target: 95%
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to other reviewers - this was set to 95 % due to codecov reporting slightly lower coverage stats than on superset-ui. This will be fixed in a follow-up PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reminder.

superset-frontend/jest.config.js Show resolved Hide resolved
zhaoyongjie and others added 3 commits November 29, 2021 16:43
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a giant leap. Thanks for all the hard work!

@stephenLYZ
Copy link
Member

Tested in local. LGTM. Thanks for the huge improvement!

@kgabryje
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@kgabryje Ephemeral environment spinning up at http://35.87.14.131:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool! Thanks for the hard work. I'm wondering if we can split CI for plugins into separate workflows just to make it easier to debug.

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually, works great. Amazing work!

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What an epic series of PRs! Amazing work @zhaoyongjie ! 🎉🎉🎉

@zhaoyongjie zhaoyongjie merged commit 3c41ff6 into master Nov 30, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@zhaoyongjie zhaoyongjie deleted the monorepo_stage_2 branch November 30, 2021 03:36
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels hold:testing! On hold for testing hold! On hold risk:many-files Change has too many files risk:refactor High risk as it involves large refactoring work size/XXL 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants