refactor(monorepo): move superset-ui to superset(stage 2) #17552

zhaoyongjie · 2021-11-25T02:55:30Z

SUMMARY

This PR implement SIP-58, move superset-ui to this repo. NOTICE: Please merge relocation-PR before merging this PR.

Move packages, plugins, scripts directories into superset_frontend
All remaining files are saved in temporary_superset_ui
add packages/* and plugins/* to lerna packages
refactor superset-generator unit test
add babel-extract.sh. packages and plugins is appended in babel.cfg

To ensure that every PR passes the CI, the monorepo-related PR is split into multiple stages.

codecov · 2021-11-25T03:33:26Z

Codecov Report

Merging #17552 (fcbcca6) into master (6604a6a) will decrease coverage by 8.35%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master   #17552      +/-   ##
==========================================
- Coverage   76.94%   68.59%   -8.36%     
==========================================
  Files        1049     1588     +539     
  Lines       56672    64931    +8259     
  Branches     7849     6961     -888     
==========================================
+ Hits        43609    44542     +933     
- Misses      12810    18499    +5689     
- Partials      253     1890    +1637

Flag	Coverage Δ
hive	`81.61% <ø> (ø)`
javascript	`57.08% <50.00%> (-14.01%)`	⬇️
mysql	`82.02% <ø> (ø)`
postgres	`82.03% <ø> (ø)`
presto	`81.90% <ø> (?)`
python	`82.52% <ø> (+0.14%)`	⬆️
sqlite	`81.71% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ntrols/src/components/CertifiedIconWithTooltip.tsx	`88.88% <ø> (ø)`
...-ui-chart-controls/src/components/ColumnOption.tsx	`91.30% <ø> (ø)`
...-chart-controls/src/components/ColumnTypeLabel.tsx	`90.00% <ø> (ø)`
...ols/src/components/ControlForm/ControlFormItem.tsx	`24.24% <ø> (ø)`
...t-controls/src/components/ControlForm/controls.tsx	`100.00% <ø> (ø)`
...hart-controls/src/components/ControlForm/index.tsx	`14.28% <ø> (ø)`
...ui-chart-controls/src/components/ControlHeader.tsx	`19.23% <ø> (ø)`
...controls/src/components/InfoTooltipWithTrigger.tsx	`100.00% <ø> (ø)`
...-ui-chart-controls/src/components/MetricOption.tsx	`95.83% <ø> (ø)`
...perset-ui-chart-controls/src/components/Select.tsx	`14.28% <ø> (ø)`
... and 1285 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6604a6a...fcbcca6. Read the comment docs.

tsconfig

update webpack config update webpack config

edit .codecov.yml

fix refactor genertor lint error

update jest.config.js allow superset-generator temporarily disallow generator unit test temporarily remove test dir in plugins ignore superet-ui-demo fix dir try to increase code coverage prettier disable generator update jest updates root jest remove generator add comments update jest config

add comments

villebro

A few comments. In general I find this works very well, amazing work! 🎉 There will inevitably be some todos that will require follow-up PRs, but I think this is already a big improvement over the current development workflow, so feeling inclined to approve this to unblock plugin development.

superset/translations/babel.cfg

villebro · 2021-11-29T07:53:44Z

.codecov.yml

@@ -14,6 +15,17 @@ coverage:
        # project coverage decrease:
        target: auto
        threshold: 0%
+      core-packages-ts:
+        target: 95%


Note to other reviewers - this was set to 95 % due to codecov reporting slightly lower coverage stats than on superset-ui. This will be fixed in a follow-up PR

Thanks for the reminder.

superset-frontend/jest.config.js

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

geido

This is a giant leap. Thanks for all the hard work!

stephenLYZ · 2021-11-29T16:30:41Z

Tested in local. LGTM. Thanks for the huge improvement!

kgabryje · 2021-11-29T16:42:17Z

/testenv up

github-actions · 2021-11-29T16:44:30Z

@kgabryje Ephemeral environment spinning up at http://35.87.14.131:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

ktmud

This is really cool! Thanks for the hard work. I'm wondering if we can split CI for plugins into separate workflows just to make it easier to debug.

kgabryje

Tested manually, works great. Amazing work!

villebro

What an epic series of PRs! Amazing work @zhaoyongjie ! 🎉🎉🎉

github-actions · 2021-11-30T00:30:20Z

Ephemeral environment shutdown and build artifacts deleted.

pull-request-size bot added the size/XXL label Nov 25, 2021

zhaoyongjie mentioned this pull request Nov 25, 2021

refactor(monorepo): move superset-ui to superset(stage 2) #17437

Closed

zhaoyongjie changed the title ~~Monorepo stage 2~~ refactor(monorepo): move superset-ui to superset(stage 2) Nov 25, 2021

zhaoyongjie force-pushed the monorepo_stage_2 branch from b52f206 to c26d3a9 Compare November 25, 2021 03:12

zhaoyongjie force-pushed the monorepo_stage_2 branch 5 times, most recently from cf6acbf to 44cbf80 Compare November 26, 2021 07:45

zhaoyongjie added risk:many-files Change has too many files risk:refactor High risk as it involves large refactoring work risk:superset-ui hold! On hold hold:testing! On hold for testing labels Nov 26, 2021

zhaoyongjie force-pushed the monorepo_stage_2 branch from 44cbf80 to bfb4a12 Compare November 26, 2021 09:53

villebro force-pushed the monorepo_stage_2 branch from bfb4a12 to 508b9a0 Compare November 26, 2021 10:51

pull-request-size bot added size/XL and removed size/XXL labels Nov 26, 2021

villebro force-pushed the monorepo_stage_2 branch 2 times, most recently from 342d5b0 to 508b9a0 Compare November 26, 2021 11:53

zhaoyongjie force-pushed the monorepo_stage_2 branch from 508b9a0 to a5addbb Compare November 26, 2021 15:51

zhaoyongjie added 8 commits November 27, 2021 21:06

move packages, plugins, scripts, shims to superset_frontend

7d6d612

update tsconfig

8287341

tsconfig

update gitignore

f9abda4

update webpack config

e931036

update webpack config update webpack config

update babel

a8d8891

update eslint

8b7a336

add workspace in packages.json

2acd1ff

edit package.json

eaaacb3

zhaoyongjie added 9 commits November 27, 2021 21:06

refine npm ci step in Dockerfile

a2cd695

check plugins

5fd5583

refresh lock file

6a2d835

update .codecov.yml

04dd930

edit .codecov.yml

refactor superset-generator

9fec0d2

fix refactor genertor lint error

add resetTranslation in singleton

c9201b9

fix mock ChartClient

01ea169

add comments

temporarily decrease ts-core coverage rate

1213309

zhaoyongjie force-pushed the monorepo_stage_2 branch from a5addbb to 1213309 Compare November 27, 2021 13:06

zhaoyongjie mentioned this pull request Nov 27, 2021

chore(translations): Add missing i18n #17525

Merged

9 tasks

add babel extract script

16eb4ce

pull-request-size bot added size/XXL and removed size/XL labels Nov 27, 2021

villebro reviewed Nov 29, 2021

View reviewed changes

zhaoyongjie and others added 3 commits November 29, 2021 16:43

Update superset/translations/babel.cfg

16c965c

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

generator test

2ea4fdb

add generator step

fcbcca6

geido approved these changes Nov 29, 2021

View reviewed changes

ktmud approved these changes Nov 29, 2021

View reviewed changes

kgabryje approved these changes Nov 29, 2021

View reviewed changes

villebro approved these changes Nov 29, 2021

View reviewed changes

zhaoyongjie merged commit 3c41ff6 into master Nov 30, 2021

zhaoyongjie deleted the monorepo_stage_2 branch November 30, 2021 03:36

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(monorepo): move superset-ui to superset(stage 2) #17552

refactor(monorepo): move superset-ui to superset(stage 2) #17552

zhaoyongjie commented Nov 25, 2021 •

edited

Loading

codecov bot commented Nov 25, 2021 •

edited

Loading

villebro left a comment

villebro Nov 29, 2021

zhaoyongjie Nov 29, 2021

geido left a comment

stephenLYZ commented Nov 29, 2021

kgabryje commented Nov 29, 2021

github-actions bot commented Nov 29, 2021

ktmud left a comment

kgabryje left a comment

villebro left a comment

github-actions bot commented Nov 30, 2021

refactor(monorepo): move superset-ui to superset(stage 2) #17552

refactor(monorepo): move superset-ui to superset(stage 2) #17552

Conversation

zhaoyongjie commented Nov 25, 2021 • edited Loading

SUMMARY

codecov bot commented Nov 25, 2021 • edited Loading

Codecov Report

villebro left a comment

Choose a reason for hiding this comment

villebro Nov 29, 2021

Choose a reason for hiding this comment

zhaoyongjie Nov 29, 2021

Choose a reason for hiding this comment

geido left a comment

Choose a reason for hiding this comment

stephenLYZ commented Nov 29, 2021

kgabryje commented Nov 29, 2021

github-actions bot commented Nov 29, 2021

ktmud left a comment

Choose a reason for hiding this comment

kgabryje left a comment

Choose a reason for hiding this comment

villebro left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 30, 2021

zhaoyongjie commented Nov 25, 2021 •

edited

Loading

codecov bot commented Nov 25, 2021 •

edited

Loading