-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add classNames for apply and clearAll buttons for superset filters #17554
feat: add classNames for apply and clearAll buttons for superset filters #17554
Conversation
Thanks @Nithin-George-Philips - great idea. Would you mind sharing an after screenshot with associated customization instructions so others can try it out. Also, if #17505 is redundant, I suggest closing that one. |
…nto add-classNames-to-superset-filter-buttons
Codecov Report
@@ Coverage Diff @@
## master #17554 +/- ##
=======================================
Coverage 77.02% 77.02%
=======================================
Files 1049 1049
Lines 56681 56681
Branches 7851 7851
=======================================
Hits 43659 43659
Misses 12769 12769
Partials 253 253
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@villebro I have provided a screenshot as well as a custom css template to obtain the same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, thanks for the contribution! 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - LGTM
…nto add-classNames-to-superset-filter-buttons
@Nithin-George-Philips Can you provide the code necessary to move the Apply Filters/Clear All buttons to the top of the field above the filter options? It seems that by default, they are at the bottom of the form. |
SUMMARY
Added className for applyAll and clearALL Button in filterBar
This is to move the sticky buttons from the top to the bottom making it intuitive to different customers.
Custom css can be used to move the buttons as well as change the UI associated with the buttons.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Sample css template to get above UI
ADDITIONAL INFORMATION