Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added option to set pod annotations on init-db pod to Helm chart. #17581

Merged

Conversation

caviliar
Copy link
Contributor

Signed-off-by: David Talbot davidtalbot100@gmail.com

SUMMARY

Add the ability to provide pod annotations for the init-db pod via the helm chart and values.yaml.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Ran helm template test . and checked the output of the Job.
Tried for:

  • no object podAnnotations:
  • no annotation podAnnotations: {}
  • 1 annotation
  • multiple annotations

ADDITIONAL INFORMATION

  • Has associated issue: Helm: ability to set annotations on init-db job pod #17580
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Signed-off-by: David Talbot <davidtalbot100@gmail.com>
@caviliar
Copy link
Contributor Author

@craig-rueda can you review this please?

Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would be great to also add deploymentAnnotations or jobAnnotations, similar to: https://github.com/apache/superset/blob/master/helm/superset/templates/deployment-worker.yaml#L28

Copy link
Member

@craig-rueda craig-rueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally - LGTM

@craig-rueda craig-rueda merged commit 95177d7 into apache:master Nov 30, 2021
@geido
Copy link
Member

geido commented Jan 25, 2022

Fixes #17580

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants