-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(monorepo): relocate deckgl to Superset #17596
Conversation
413bc56
to
2301897
Compare
2301897
to
c85f44b
Compare
Codecov Report
@@ Coverage Diff @@
## master #17596 +/- ##
==========================================
- Coverage 68.59% 67.77% -0.82%
==========================================
Files 1588 1657 +69
Lines 64948 66291 +1343
Branches 6963 7146 +183
==========================================
+ Hits 44548 44932 +384
- Misses 18510 19470 +960
+ Partials 1890 1889 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
LGTM |
/testenv up |
@kgabryje Ephemeral environment spinning up at http://54.214.111.155:8080. Credentials are |
import { SuperChart } from '@superset-ui/core'; | ||
import { ArcChartPlugin } from '@superset-ui/legacy-preset-chart-deckgl'; | ||
import payload from './payload'; | ||
import dummyDatasource from '../../../../shared/dummyDatasource'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: can we simplify this import? Maybe by setting a base path in tsconfig.json
to storybook
? Then we could import like import dummyDatasource from 'storybook/shared/dummyDatasource';
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(comment also applies to other files below that import dummyDatasource like that)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The absolute import
depends on how to locate the storybook/shared
module. (Maybe needed module alias in somewhere).
so relative import
is straightforward here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
This PR move Deckgl to plugins directory
packages/superset-ui-demo/stories/plugins
tsconfig.json
into packagesrc/factory.jsx
totypescript
legacy-preset-chart-deckgl
fromjest.config.js
(in order to mapping this plugin for test)controlPanel
totypescript
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION