refactor(monorepo): frontend code cleanup after monorepo #17639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaoyongjie
changed the title
zhaoyongjie
commented
Dec 3, 2021
| "noImplicitAny": true, | ||
| "noImplicitReturns": true, | ||
| "noImplicitThis": true, | ||
| "noUnusedLocals": true, | ||
| "outDir": "./dist", | ||
| "pretty": true, |
There was a problem hiding this comment.
"pretty" default value is true, remove it.
Codecov Report
@@ Coverage Diff @@
## master #17639 +/- ##
=======================================
Coverage 68.75% 68.75%
=======================================
Files 1595 1595
Lines 65184 65184
Branches 6945 6945
=======================================
Hits 44814 44814
Misses 18488 18488
Partials 1882 1882
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
ktmud
approved these changes
Dec 3, 2021
| @@ -33,20 +24,42 @@ | |||
| ], | |||
| "@superset-ui/plugin-chart-*": ["./plugins/plugin-chart-*/src"], | |||
| "@superset-ui/preset-chart-*": ["./plugins/preset-chart-*/src"], | |||
There was a problem hiding this comment.
I believe L15-26 can be updated to
"@superset-ui/*": [
"./node_modules/@superset-ui/*/src",
"./node_modules/@superset-ui/*",
],There was a problem hiding this comment.
unfortunately, I got this error when I make this change. I will make a separate PR to improve it.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
TESTING INSTRUCTIONS
CI passed
ADDITIONAL INFORMATION