Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prophet): enable confidence intervals and y_hat without forecast #17658

Merged
merged 2 commits into from
Dec 8, 2021

Conversation

exemplary-citizen
Copy link
Contributor

SUMMARY

Allows users to add confidence intervals and y_hat to charts with zero forecast period

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Screen Shot 2021-12-05 at 11 51 28 PM
After:
Screen Shot 2021-12-06 at 1 28 49 AM

TESTING INSTRUCTIONS

Added tests to tests/integration_tests/pandas_postprocessing_tests.py

ADDITIONAL INFORMATION

Addresses part of #17510

  • Has associated issue: [Prophet]Leverage predictive analytics to trigger alerts #17510
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

cc: @villebro @bkyryliuk

@superset-github-bot superset-github-bot bot added the dropbox Dropbox related label Dec 6, 2021
@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #17658 (00357e5) into master (2ae83fa) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17658      +/-   ##
==========================================
- Coverage   68.85%   68.73%   -0.12%     
==========================================
  Files        1597     1597              
  Lines       65251    65251              
  Branches     6950     6950              
==========================================
- Hits        44927    44850      -77     
- Misses      18439    18516      +77     
  Partials     1885     1885              
Flag Coverage Δ
hive ?
mysql 82.10% <100.00%> (ø)
postgres 82.11% <100.00%> (ø)
python 82.20% <100.00%> (-0.26%) ⬇️
sqlite 81.80% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/charts/schemas.py 99.33% <ø> (ø)
superset/utils/pandas_postprocessing.py 85.80% <100.00%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.27% <0.00%> (-16.99%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/db_engine_specs/presto.py 83.50% <0.00%> (-0.84%) ⬇️
superset/db_engine_specs/base.py 88.29% <0.00%> (-0.39%) ⬇️
superset/connectors/sqla/models.py 86.85% <0.00%> (-0.23%) ⬇️
superset/utils/core.py 89.64% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ae83fa...00357e5. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice, I hadn't thought of this use case 👍 LGTM if you agree with that minor change.

superset/utils/pandas_postprocessing.py Outdated Show resolved Hide resolved
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro villebro merged commit cd88b8e into apache:master Dec 8, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dropbox Dropbox related size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants