fix: Dashboard header negative margin on save

[geido]

SUMMARY

Fixes an issue that was cutting the header with a negative margin

BEFORE

AFTER

USA.Births.Names.copy.sss.mp4

TESTING INSTRUCTIONS

1. Open a Dashboard
2. Set the certification details in the properties
3. Save and observe the header

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #17690 (65be822) into master (8c25f2f) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##           master   #17690   +/-   ##
=======================================
  Coverage   68.86%   68.86%           
=======================================
  Files        1598     1598           
  Lines       65297    65298    +1     
  Branches     6952     6953    +1     
=======================================
+ Hits        44966    44967    +1     
  Misses      18446    18446           
  Partials     1885     1885           

Flag	Coverage Δ
javascript	57.47% <75.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...frontend/src/dashboard/components/Header/index.jsx	59.44% <ø> (+0.41%)	⬆️
...et-frontend/src/components/EditableTitle/index.tsx	73.07% <75.00%> (-0.61%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c25f2f...65be822. Read the comment docs.

[rusackas]

/testenv up

[rusackas]

This component probably shouldn't even exist, but that's a different discussion ;)

[geido]

@rusackas I think the name is misleading here. This is intended to be more than just an icon, it's more like a tiny component.

[kgabryje]

Then maybe we can change the name to CertifiedBadge to avoid confusion?

[geido]

Yes. I will open a separate PR

[github-actions]

@rusackas Ephemeral environment spinning up at http://34.209.90.108:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[kgabryje]

1 suggestion to rename a component, otherwise LGTM

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.