refactor(monorepo): change coverage of core to 100% #17698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17698 +/- ##
==========================================
- Coverage 68.13% 67.75% -0.39%
==========================================
Files 1653 1602 -51
Lines 66247 64098 -2149
Branches 7107 6772 -335
==========================================
- Hits 45138 43430 -1708
+ Misses 19220 18815 -405
+ Partials 1889 1853 -36
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
zhaoyongjie
commented
Dec 9, 2021
| const newScale = new CategoricalColorScale( | ||
| scheme?.colors ?? [], | ||
| this.forcedItems, | ||
| ); | ||
|
|
||
| return newScale; | ||
| return new CategoricalColorScale(scheme?.colors ?? [], this.forcedItems); |
etr2460
approved these changes
Dec 10, 2021
zhaoyongjie
commented
Dec 11, 2021
Comment on lines
-19
to
+26
| import seedrandom from 'seedrandom'; | ||
|
|
||
| let random = seedrandom('superset-ui'); | ||
| import _seedrandom from 'seedrandom'; | ||
|
|
||
| export function seed(seed: string) { | ||
| random = seedrandom(seed); | ||
| return random; | ||
| return _seedrandom(seed); | ||
| } | ||
|
|
||
| export function seedRandom() { | ||
| return random(); | ||
| return _seedrandom('superset-ui')(); |
There was a problem hiding this comment.
minor refactor, to avoid duplicate names(seedrandom).
zhaoyongjie
commented
Dec 11, 2021
Comment on lines
+30
to
-42
| jest.spyOn(logging, 'debug').mockImplementation(); | ||
| jest.spyOn(logging, 'log').mockImplementation(); | ||
| jest.spyOn(logging, 'info').mockImplementation(); | ||
| expect(() => { | ||
| logging.debug(); | ||
| logging.log(); | ||
| logging.info(); | ||
| }).not.toThrow(); | ||
| expect(() => { | ||
| logging.warn('warn'); | ||
| }).toThrow('warn'); | ||
| expect(() => { | ||
| logging.error('error'); | ||
| }).toThrow('error'); |
There was a problem hiding this comment.
mock console output, to make clear test output.
before
(superset) yongjie.zhao@:superset-frontend$ rm -rf coverage && npx jest --clearCache && NODE_ENV=test npx jest packages/superset-ui-core/test/utils/logging.test.ts
Cleared /private/var/folders/10/0l8mvpf52jx6t3p68mndwn7m0000gn/T/jest_dx
PASS packages/superset-ui-core/test/utils/logging.test.ts (9.898 s)
logging
✓ should pipe to `console` methods (4487 ms)
✓ should use noop functions when console unavailable (72 ms)
console.debug
undefined
at packages/superset-ui-core/test/utils/logging.test.ts:33:15
console.log
undefined
at packages/superset-ui-core/test/utils/logging.test.ts:34:15
console.info
undefined
at packages/superset-ui-core/test/utils/logging.test.ts:35:15
Test Suites: 1 passed, 1 total
Tests: 2 passed, 2 total
Snapshots: 0 total
Time: 10.875 s
Ran all test suites matching /packages\/superset-ui-core\/test\/utils\/logging.test.ts/i.
After
(superset) yongjie.zhao@:superset-frontend$ rm -rf coverage && npx jest --clearCache && NODE_ENV=test npx jest packages/superset-ui-core/test/utils/logging.test.ts
Cleared /private/var/folders/10/0l8mvpf52jx6t3p68mndwn7m0000gn/T/jest_dx
PASS packages/superset-ui-core/test/utils/logging.test.ts (8.997 s)
logging
✓ should pipe to `console` methods (4409 ms)
✓ should use noop functions when console unavailable (84 ms)
Test Suites: 1 passed, 1 total
Tests: 2 passed, 2 total
Snapshots: 0 total
Time: 9.707 s
Ran all test suites matching /packages\/superset-ui-core\/test\/utils\/logging.test.ts/i.
zhaoyongjie
commented
Dec 13, 2021
| @@ -33,13 +33,6 @@ import { | |||
| } from './types'; | |||
| import { DEFAULT_FETCH_RETRY_OPTIONS, DEFAULT_BASE_URL } from './constants'; | |||
|
|
|||
| function redirectUnauthorized() { | |||
There was a problem hiding this comment.
The function move into class
|
LGTM |
| @@ -16,7 +16,7 @@ coverage: | |||
| target: auto | |||
| threshold: 0% | |||
| core-packages-ts: | |||
| target: 95% | |||
| target: 100% | |||
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
make coverage of core package to 100%
link to shortcut: https://app.shortcut.com/preset/story/32255/yongjie-with-help-get-s-ui-packages-plugins-back-to-100-test-coverage
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After
TESTING INSTRUCTIONS
CI
ADDITIONAL INFORMATION