-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: local warning in the frontend development #17727
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17727 +/- ##
==========================================
- Coverage 68.11% 68.11% -0.01%
==========================================
Files 1653 1653
Lines 66374 66367 -7
Branches 7121 7121
==========================================
- Hits 45211 45204 -7
Misses 19266 19266
Partials 1897 1897
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@stephenLYZ can you add a description to describe the proposed changes. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested to resolve the errors, thanks for cleaning these up!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
Currently, there were a few warnings prompted when the frontend service was started locally, and this PR fixes most of them. (Three remaining)
resolved:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION