Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import DB errors #17748

Merged
merged 1 commit into from
Dec 15, 2021
Merged

fix: import DB errors #17748

merged 1 commit into from
Dec 15, 2021

Conversation

betodealmeida
Copy link
Member

SUMMARY

When importing a dashboard that has a database with a masked password we ask for the password even though later we reject the import because the type is wrong.

This PR improves the logic of hasTerminalValidation, a helper function that determines if we should prompt for password and/or overwrite, or if we should show an error message on a failed import.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Added unit test covering the regression.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #17748 (863600c) into master (2633bcc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17748   +/-   ##
=======================================
  Coverage   67.72%   67.72%           
=======================================
  Files        1602     1602           
  Lines       64146    64147    +1     
  Branches     6773     6774    +1     
=======================================
+ Hits        43442    43443    +1     
  Misses      18851    18851           
  Partials     1853     1853           
Flag Coverage Δ
javascript 54.83% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/views/CRUD/utils.tsx 54.46% <100.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2633bcc...863600c. Read the comment docs.

@betodealmeida betodealmeida merged commit 2a6e5e5 into apache:master Dec 15, 2021
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants