Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update contribuing docs #17754

Merged
merged 1 commit into from
Dec 17, 2021
Merged

docs: update contribuing docs #17754

merged 1 commit into from
Dec 17, 2021

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Dec 15, 2021 •
edited
Loading

SUMMARY

  1. remove unused superset-ui section
  2. fix dead link

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@zhaoyongjie zhaoyongjie changed the title doc: update contribuing docs docs: update contribuing docs Dec 15, 2021
@villebro villebro requested a review from riahk December 15, 2021 07:15
@villebro
Copy link
Member

@riahk can you take a look at these changes? FYI @zhaoyongjie , Moriah is moving these sections into the docs section, so in the future the majority of this will be featured in the official documentation.

riahk
riahk approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@riahk riahk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One slight nit. Thank you for this!

CONTRIBUTING.md
@@ -728,7 +715,7 @@ def sqrt(x: Union[float, int]) -> Union[float, int]:
return math.sqrt(x)
```

### TypeScript
### TypeScript Typing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels a bit redundant imo

Copy link
Member Author

@zhaoyongjie zhaoyongjie Dec 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Typescript in Linting and Typescript in Typescript are in conflict, so the Table of Contents hasn't typescript in Linting section

image

@riahk riahk merged commit dc50578 into apache:master Dec 17, 2021
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
@zhaoyongjie @shcoderAlex
doc: update contribuing docs (apache#17754)
2c2d341
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@zhaoyongjie @bwang221
doc: update contribuing docs (apache#17754)
a10d5da
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riahk riahk riahk approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhaoyongjie @villebro @riahk @mistercrunch