Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump react-resize-detector #17764

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Conversation

villebro
Copy link
Member

@villebro villebro commented Dec 15, 2021

SUMMARY

We are currently using an old release candidate 6.0.1-rc.1 of react-resize-detector (1 year old) that officially only supports React 17. In addition to bumping it to the latest official release (v. 6.7.6), v. 6.3.3 reintroduced support for v.16, which is what Superset is currently on (https://github.com/maslianok/react-resize-detector/releases):

image

Tested resizing Explore view (only place where the package is used) to ensure that it works correctly.

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #17764 (6d88a2e) into master (124af4c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17764   +/-   ##
=======================================
  Coverage   67.71%   67.71%           
=======================================
  Files        1604     1604           
  Lines       64186    64186           
  Branches     6786     6786           
=======================================
  Hits        43464    43464           
  Misses      18867    18867           
  Partials     1855     1855           
Flag Coverage Δ
javascript 54.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 124af4c...6d88a2e. Read the comment docs.

@villebro villebro merged commit 6d97e89 into apache:master Dec 15, 2021
@villebro villebro deleted the villebro/bump-rrd branch December 15, 2021 15:14
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants