-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(plugin-chart-pivot-table): change order of Columns and Rows controls #17798
chore(plugin-chart-pivot-table): change order of Columns and Rows controls #17798
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with non-blocking suggestion
@@ -95,10 +95,14 @@ const config: ControlPanelConfig = { | |||
name: 'row_limit', | |||
config: { | |||
...sharedControls.row_limit, | |||
label: t('Cell limit'), | |||
description: t('Limits the number of cells that get displayed.'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this is more accurate?
description: t('Limits the number of cells that get displayed.'), | |
description: t('Limits the number of cells that get retieved.'), |
9b44861
to
c7d4c2d
Compare
Codecov Report
@@ Coverage Diff @@
## master #17798 +/- ##
=======================================
Coverage 67.18% 67.18%
=======================================
Files 1609 1609
Lines 64796 64796
Branches 6855 6855
=======================================
Hits 43530 43530
Misses 19410 19410
Partials 1856 1856
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
SUMMARY
Since column headers are visually above rows, it feels more logical to place the columns control above the rows control.
This PR changes the order of those controls
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
CC @kasiazjc