Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(plugin-chart-pivot-table): change order of Columns and Rows controls #17798

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

kgabryje
Copy link
Member

SUMMARY

Since column headers are visually above rows, it feels more logical to place the columns control above the rows control.
This PR changes the order of those controls

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

CC @kasiazjc

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with non-blocking suggestion

@@ -95,10 +95,14 @@ const config: ControlPanelConfig = {
name: 'row_limit',
config: {
...sharedControls.row_limit,
label: t('Cell limit'),
description: t('Limits the number of cells that get displayed.'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is more accurate?

Suggested change
description: t('Limits the number of cells that get displayed.'),
description: t('Limits the number of cells that get retieved.'),

@kgabryje kgabryje force-pushed the chore/pivot-table-columns-rows branch from 9b44861 to c7d4c2d Compare December 17, 2021 12:00
@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #17798 (1ecca35) into master (9c9edbe) will not change coverage.
The diff coverage is n/a.

❗ Current head 1ecca35 differs from pull request most recent head c7d4c2d. Consider uploading reports for the commit c7d4c2d to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17798   +/-   ##
=======================================
  Coverage   67.18%   67.18%           
=======================================
  Files        1609     1609           
  Lines       64796    64796           
  Branches     6855     6855           
=======================================
  Hits        43530    43530           
  Misses      19410    19410           
  Partials     1856     1856           
Flag Coverage Δ
javascript 53.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ugin-chart-pivot-table/src/plugin/controlPanel.tsx 12.50% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c9edbe...c7d4c2d. Read the comment docs.

@kgabryje kgabryje merged commit b5dca4e into apache:master Dec 17, 2021
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants