feat(plugin-chart-pivot-table): support series limit #17803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgabryje
changed the title
kgabryje
changed the title
Codecov Report
@@ Coverage Diff @@
## master #17803 +/- ##
==========================================
- Coverage 67.18% 66.97% -0.21%
==========================================
Files 1609 1608 -1
Lines 64796 64798 +2
Branches 6855 6851 -4
==========================================
- Hits 43530 43399 -131
- Misses 19410 19540 +130
- Partials 1856 1859 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
villebro
reviewed
Dec 20, 2021
| params = json.loads(slc.params) | ||
| legacy_order_by = params.pop("legacy_order_by", None) | ||
| if legacy_order_by: | ||
| params["timeseries_limit_metric"] = legacy_order_by |
| for slc in slices: | ||
| try: | ||
| params = json.loads(slc.params) | ||
| timeseries_limit_metric = params.pop("timeseries_limit_metric", None) |
| ], | ||
| [ | ||
| { | ||
| name: 'timeseries_limit_metric', |
There was a problem hiding this comment.
Let's rather use series_limit_metric, as timeseries_limit_metric is now deprecated.
superset-frontend/plugins/plugin-chart-pivot-table/src/plugin/controlPanel.tsx
Show resolved
Hide resolved
villebro
reviewed
Dec 20, 2021
| @@ -90,15 +89,40 @@ const config: ControlPanelConfig = { | |||
| ], | |||
| ['adhoc_filters'], | |||
| emitFilterControl, | |||
| ['limit'], | |||
There was a problem hiding this comment.
oh, also prefer the use of series_limit over limit
zhaoyongjie
requested changes
Dec 21, 2021
Thank you @zhaoyongjie, well spotted! Issue fixed. Can you retest?
|
zhaoyongjie
approved these changes
Dec 21, 2021
shcoderAlex
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 7, 2022
* feat(plugin-chart-pivot-table): support series limit * Add a migration * Use non-legacy series limit controls * Add a todo comment * Bug fix
bwang221
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 10, 2022
* feat(plugin-chart-pivot-table): support series limit * Add a migration * Use non-legacy series limit controls * Add a todo comment * Bug fix
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Support series limit along with row limit in Pivot Table v2.
Migration benchmark results:
10+: 0.38 s
100+: 0.25 s
1000+: 0.24 s
10000+: 0.36 s
100000+: 0.46 s
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
CC @rusackas @graceguo-supercat