-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: failed mypy in master branch #17886
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #17886 +/- ##
==========================================
- Coverage 67.10% 66.89% -0.21%
==========================================
Files 1609 1609
Lines 64897 64897
Branches 6866 6866
==========================================
- Hits 43547 43414 -133
- Misses 19484 19617 +133
Partials 1866 1866
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
718ab47
to
c22b4ce
Compare
SUMMARY
it solved the failed mypy that prevents merging of new PRs
Using additional_dependencies: [types-all] in mypy pre-commit is wrong. it installs stubs types for not matching versions.
for example, it installs stub for Redis 4.1 while superset uses Redis 3.5.3
meanwhile, I added installations of superset base.txt requirements until a better solution like declaring all the required stubs packages inside a development requirements file.