Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(explore): make adhoc columns available without UX BETA ff #17921

Merged
merged 2 commits into from
Feb 4, 2022

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Jan 4, 2022

SUMMARY

The feature introduced in #17379 was available only with UX BETA feature flag enabled. Since we received positive feedback from the users who tried the feature out, it's time to make it available to everyone!
This PR removes the dependency on UX BETA feature flag. To learn more about the feature, check out the linked PR

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

TESTING INSTRUCTIONS

  1. Disable UX_BETA feature flag and enable drag and drop feature flag
  2. Create a chart
  3. Verify that adhoc columns feature is available and works as described in feat(explore): adhoc column expressions [ID-3] #17379

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

CC @rusackas @jinghua-qa @rosemarie-chiu

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #17921 (1d897b8) into master (6e59a51) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17921   +/-   ##
=======================================
  Coverage   67.07%   67.07%           
=======================================
  Files        1609     1609           
  Lines       64899    64896    -3     
  Branches     6866     6864    -2     
=======================================
- Hits        43533    43532    -1     
+ Misses      19500    19499    -1     
+ Partials     1866     1865    -1     
Flag Coverage Δ
javascript 53.77% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ols/DndColumnSelectControl/ColumnSelectPopover.tsx 14.73% <0.00%> (+0.15%) ⬆️
...ColumnSelectControl/ColumnSelectPopoverTrigger.tsx 73.68% <100.00%> (+1.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e59a51...1d897b8. Read the comment docs.

@jinghua-qa
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2022

@jinghua-qa Ephemeral environment creation is currently limited to committers.

@rusackas
Copy link
Member

rusackas commented Jan 4, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2022

@rusackas Ephemeral environment spinning up at http://54.213.1.12:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@jinghua-qa
Copy link
Member

I am not able to see adhoc columns feature in groupby in the test env, do i need to enable dnd and dnd hybrid FF?

Screen.Recording.2022-01-04.at.11.03.54.AM.mov

@kgabryje
Copy link
Member Author

kgabryje commented Jan 4, 2022

I am not able to see adhoc columns feature in groupby in the test env, do i need to enable dnd and dnd hybrid FF?

Screen.Recording.2022-01-04.at.11.03.54.AM.mov

Yes, DnD is a requirement, sorry for not putting that information in PR description. Let me update

@jinghua-qa
Copy link
Member

/testenv up FEATURE_ENABLE_EXPLORE_DRAG_AND_DROP=true FEATURE_ENABLE_DND_WITH_CLICK_UX=true

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2022

@jinghua-qa Ephemeral environment spinning up at http://54.218.150.117:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@jinghua-qa jinghua-qa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgabryje kgabryje merged commit 6cad7b1 into apache:master Feb 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2022

Ephemeral environment shutdown and build artifacts deleted.

shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
…he#17921)

* chore(explore): make adhoc columns available without UX BETA ff

* Remove redundant imports
ofekisr pushed a commit to nielsen-oss/superset that referenced this pull request Feb 8, 2022
…he#17921)

* chore(explore): make adhoc columns available without UX BETA ff

* Remove redundant imports
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
…he#17921)

* chore(explore): make adhoc columns available without UX BETA ff

* Remove redundant imports
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants