Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: sqleditorleftbar to typescript #17926

Merged
merged 17 commits into from
Jan 28, 2022
Merged

refactor: sqleditorleftbar to typescript #17926

merged 17 commits into from
Jan 28, 2022

Commits on Jan 27, 2022

  1. Creating draft PR to address bug

    @JosueLugaro
    JosueLugaro committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    88ccf68 View commit details
    Browse the repository at this point in the history

  2. Still working on solving re rendering bug

    @JosueLugaro
    JosueLugaro committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    00c919d View commit details
    Browse the repository at this point in the history

  3. Cleaning up in preparation for push

    @JosueLugaro
    JosueLugaro committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    7fa4b7b View commit details
    Browse the repository at this point in the history

  4. Starting conversion to TypeScript

    @JosueLugaro
    JosueLugaro committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    d67c1ae View commit details
    Browse the repository at this point in the history

  5. Working on conversion

    @JosueLugaro
    JosueLugaro committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    efbb029 View commit details
    Browse the repository at this point in the history

  6. Continued working on typescript conversion, referenced other files fo… 

    …r different types, still a rough version of final product
    @JosueLugaro
    JosueLugaro committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    7905ab3 View commit details
    Browse the repository at this point in the history

  7. Added type assertion to actions in props, and added types to some com… 

    …ponent functions
    @JosueLugaro
    JosueLugaro committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    7042b79 View commit details
    Browse the repository at this point in the history

  8. Progress on typescript conversion

    @JosueLugaro
    JosueLugaro committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    1f1b40f View commit details
    Browse the repository at this point in the history

  9. Fixed typing issue on collapseStyles

    @JosueLugaro
    JosueLugaro committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    d998f20 View commit details
    Browse the repository at this point in the history

  10. Fixed styling on div, child of StyledScrollbarContainer

    @JosueLugaro
    JosueLugaro committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    ced28ef View commit details
    Browse the repository at this point in the history

  11. Attempting to address issues with the actions passed into the TableEl… 

    …ement
    @JosueLugaro
    JosueLugaro committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    38b91c8 View commit details
    Browse the repository at this point in the history

  12. Resolved typescript warning on actions of the TableElement component

    @JosueLugaro
    JosueLugaro committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    2c327a4 View commit details
    Browse the repository at this point in the history

  13. Made changes suggested by Arash

    @JosueLugaro
    JosueLugaro committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    34c7645 View commit details
    Browse the repository at this point in the history

  14. Tested the component without dbId, cleaned up lingering comments

    @JosueLugaro
    JosueLugaro committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    5d26a63 View commit details
    Browse the repository at this point in the history

  15. Made more changes suggested by Arash, removed offline from the SqlEdi… 

    …torLeftBarProps interface
    @JosueLugaro
    JosueLugaro committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    1cc8a00 View commit details
    Browse the repository at this point in the history

  16. Made change suggested by Hugh

    @JosueLugaro
    JosueLugaro committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    c07f7a7 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2022

  1. Changed the expanded type from any to boolean

    @JosueLugaro
    JosueLugaro committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    cc9fada View commit details
    Browse the repository at this point in the history