fix(docs): update clickhouse.mdx #17937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a contradiction on this page - the requirements show `clickhouse-sqlalchemy` and then there is this sentence stating that the recommended connector is `sqlalchemy-clickhouse`, which is somewhat of an abandoned driver that is not seeing any activity in Github. I would suggest either removing the sentence about "recommended connector" or changing the link (as I have done in this PR).
villebro
approved these changes
Jan 7, 2022
shcoderAlex
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 7, 2022
There is a contradiction on this page - the requirements show `clickhouse-sqlalchemy` and then there is this sentence stating that the recommended connector is `sqlalchemy-clickhouse`, which is somewhat of an abandoned driver that is not seeing any activity in Github. I would suggest either removing the sentence about "recommended connector" or changing the link (as I have done in this PR).
bwang221
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 10, 2022
There is a contradiction on this page - the requirements show `clickhouse-sqlalchemy` and then there is this sentence stating that the recommended connector is `sqlalchemy-clickhouse`, which is somewhat of an abandoned driver that is not seeing any activity in Github. I would suggest either removing the sentence about "recommended connector" or changing the link (as I have done in this PR).
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a contradiction on this page - the requirements show
clickhouse-sqlalchemyand then there is this sentence stating that the recommended connector issqlalchemy-clickhouse, which is somewhat of an abandoned driver that is not seeing any activity in Github. I would suggest either removing the sentence about "recommended connector" or changing the link (as I have done in this PR).SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION