Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix 'button' misspelling in list_with_checkboxes #17942

Merged
merged 1 commit into from
Jan 6, 2022
Merged

chore: Fix 'button' misspelling in list_with_checkboxes #17942

merged 1 commit into from
Jan 6, 2022

Conversation

acrks
Copy link
Contributor

@acrks acrks commented Jan 6, 2022

SUMMARY

Corrected line 82 in list_with_checkboxes, from 'buttom' to 'button'

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Check spelling when running Superset

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@acrks acrks marked this pull request as ready for review January 6, 2022 00:51
eschutho
eschutho approved these changes Jan 6, 2022
View reviewed changes
Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @acrks! Looks good!

@lyndsiWilliams lyndsiWilliams added the Superset-Community-Partners Preset community partner program participants label Jan 6, 2022
lyndsiWilliams
lyndsiWilliams approved these changes Jan 6, 2022
View reviewed changes
Copy link
Member

@lyndsiWilliams lyndsiWilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@lyndsiWilliams lyndsiWilliams merged commit f75908b into apache:master Jan 6, 2022
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
@acrks @shcoderAlex
Fixed spelling error (apache#17942)
7bc144d
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@acrks @bwang221
Fixed spelling error (apache#17942)
9ba1733
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyndsiWilliams lyndsiWilliams lyndsiWilliams approved these changes

@eschutho eschutho eschutho approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS Superset-Community-Partners Preset community partner program participants 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acrks @eschutho @lyndsiWilliams @mistercrunch