Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate QueryTable component from jsx to tsx #17944

Merged
merged 16 commits into from
Feb 11, 2022
Merged

chore: migrate QueryTable component from jsx to tsx #17944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
69fdea9
chore: fix misspelling of button
woolnerd Dec 21, 2021
3f1c182
Merge pull request #1 from DavidWoolner/davidwoolner/misspelling-chore
AAfghahi Dec 21, 2021
0d0263a
pull from repo
MayUWish Jan 6, 2022
404be9f
Merge branch 'master' of https://github.com/apache/superset
MayUWish Jan 7, 2022
db2a16b
Merge branch 'master' of https://github.com/apache/superset
MayUWish Jan 7, 2022
060d00d
changed QuerySearch/index.jsx to index.tsx
MayUWish Jan 5, 2022
7e22aff
updated Query type at src/SqlLab/types.ts/Query and extended it into …
MayUWish Jan 6, 2022
13c5838
updated defaultQueryLimit to be optional at ResultSetProps of superse…
MayUWish Jan 6, 2022
6746b54
moved statusAttributes into useMemo hook so that it will not make the…
MayUWish Jan 6, 2022
7ec7feb
reset package-lock.json and package.json at frontend
MayUWish Jan 6, 2022
0c1a6e7
Acquired redux rootestate type for SqlLab, to be used at useSelector(…
MayUWish Jan 6, 2022
9a2cef4
updated query to be Query type and added a comment for q.status on li…
MayUWish Jan 6, 2022
c0ae220
updated queryTable for typescript conversion
MayUWish Jan 17, 2022
e521a26
updated actions type on QueryHistory and QuerySearch
MayUWish Jan 20, 2022
bea7e97
updated type for actions in SouthPane
MayUWish Jan 20, 2022
7cc7c73
created type for SqlLab redux
MayUWish Jan 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion superset-frontend/src/SqlLab/components/QueryHistory/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,13 @@ import QueryTable from 'src/SqlLab/components/QueryTable';

interface QueryHistoryProps {
queries: Query[];
actions: Record<string, unknown>;
actions: {
queryEditorSetSql: Function;
cloneQueryToNewTab: Function;
fetchQueryResults: Function;
clearQueryResults: Function;
removeQuery: Function;
};
displayLimit: number;
}

Expand Down
5 changes: 5 additions & 0 deletions superset-frontend/src/SqlLab/components/QuerySearch/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,11 @@ interface QuerySearchProps {
actions: {
addDangerToast: (msg: string) => void;
setDatabases: (data: Record<string, any>) => Record<string, any>;
queryEditorSetSql: Function;
cloneQueryToNewTab: Function;
fetchQueryResults: Function;
clearQueryResults: Function;
removeQuery: Function;
};
displayLimit: number;
}
Expand Down
2 changes: 2 additions & 0 deletions superset-frontend/src/SqlLab/components/QueryTable/QueryTable.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,13 @@ import TableView from 'src/components/TableView';
import TableCollection from 'src/components/TableCollection';
import { Provider } from 'react-redux';
import { queries, user } from 'src/SqlLab/fixtures';
import * as actions from 'src/SqlLab/actions/sqlLab';

describe('QueryTable', () => {
const mockedProps = {
queries,
displayLimit: 100,
actions,
};
it('is valid', () => {
expect(React.isValidElement(<QueryTable displayLimit={100} />)).toBe(true);
Expand Down
Loading