fix: update slug name #17961
Merged
fix: update slug name #17961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkdotson
requested review from
michael-s-molina,
geido,
zhaoyongjie and
villebro
Codecov Report
@@ Coverage Diff @@
## master #17961 +/- ##
=======================================
Coverage 67.07% 67.07%
=======================================
Files 1609 1609
Lines 64905 64906 +1
Branches 6868 6868
=======================================
+ Hits 43537 43538 +1
Misses 19502 19502
Partials 1866 1866
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx
Outdated
Show resolved
Hide resolved
| @@ -216,6 +216,9 @@ const FilterBar: React.FC<FiltersBarProps> = ({ | |||
| } | |||
| newParams.set(URL_PARAMS.nativeFiltersKey.name, dataMaskKey); | |||
|
|
|||
| // pathname could be updated somewhere else through windows.history | |||
| // keep react router history in sync with window history | |||
| history.location.pathname = window.location.pathname; | |||
There was a problem hiding this comment.
Won't this problem happen elsewhere too? Is there a global solution for it?
michael-s-molina
approved these changes
Jan 7, 2022
…rBar/index.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
3 tasks
rosemarie-chiu
pushed a commit
to preset-io/superset
that referenced
this pull request
Jan 10, 2022
* fix: fix update slug name * Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> (cherry picked from commit 765c72a)
|
🏷 2022.1 |
eschutho
pushed a commit
that referenced
this pull request
Jan 27, 2022
* fix: fix update slug name * Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
shcoderAlex
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 7, 2022
* fix: fix update slug name * Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
bwang221
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 10, 2022
* fix: fix update slug name * Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
mistercrunch
added
🍒 1.4.1
🍒 1.4.2
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This Pr fixes an issue where if you update the slug name of dashboard in the properties modal it would not reflect the change on save. This occured because the react-router is out of sync with the window state.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
https://user-images.githubusercontent.com/17326228/148497218-8177ef09-3412-4f90-aaa3-d5e6ce58802d.mov
after
Screen.Recording.2022-01-06.at.9.38.21.PM.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION