-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: unbreak pip-compile-multi #17963
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17963 +/- ##
=======================================
Coverage 67.07% 67.07%
=======================================
Files 1609 1609
Lines 64905 64905
Branches 6868 6868
=======================================
Hits 43537 43537
Misses 19502 19502
Partials 1866 1866
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@@ -19,3 +19,4 @@ | |||
pyrsistent>=0.16.1,<0.17 | |||
zipp==3.4.1 | |||
sasl==0.3.1 | |||
wrapt==1.12.1 # required by astroid<2.9 until we bump pylint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be on testing.in
then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch - As it turns out, wrapt
is also required by deprecated
, which in turn is pulled in by redis
, so it appears we need this in base.in
after all
* chore: unbreak pip-compile-multi * add docs
* chore: unbreak pip-compile-multi * add docs
SUMMARY
Currently there are a few conflicts in the python dependencies:
packaging==23.0
depends onpyparsing<3
, which causes an error when runningpip-compile-multi
. By upgradingpyparsing
to the latest stable version we can also upgrade to the latest version ofpackaging
.wrapt<1.13
is required by the version ofasteroid
that our current version ofpylint
depends on. Until we bumppylint
we need to pinwrapt=1.12.1
.After these changes running
pip-compile-multi
finishes successfully, and Superset appears to run smoothly. However, I decided not to commit the updated lock files in this PR, as this PR is just intended to fix the version conflicts (we can follow up with a full lock file bump later).In addition, the dependency section in
CONTRIBUTING.md
is updated to reflect the workflows for 1) bumping a single python package 2) bumping all python deps.AFTER
After the changes, bumping the lock files works correctly:
BEFORE
Previously running
pip-compile-multi
failed with an exception:ADDITIONAL INFORMATION