Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump typescript to 4.5.4, and adjust storybook story. #17971

Merged
merged 3 commits into from
Jan 10, 2022

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Jan 8, 2022

SUMMARY

Saw that This PR was failing due to some esoteric linting issue in a storybook issue. This makes the same bump, also bumps Superset, and fixes the Story.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Verified Storybook works fine locally. CI passing should cover the rest.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jan 8, 2022

Codecov Report

Merging #17971 (a1cfb2b) into master (fecb6d9) will not change coverage.
The diff coverage is n/a.

❗ Current head a1cfb2b differs from pull request most recent head 9d5dbcb. Consider uploading reports for the commit 9d5dbcb to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17971   +/-   ##
=======================================
  Coverage   67.08%   67.08%           
=======================================
  Files        1611     1611           
  Lines       64919    64919           
  Branches     6871     6871           
=======================================
  Hits        43548    43548           
  Misses      19504    19504           
  Partials     1867     1867           
Flag Coverage Δ
javascript 53.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fecb6d9...9d5dbcb. Read the comment docs.

@rusackas rusackas requested a review from etr2460 January 8, 2022 04:20
Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the upgrade! I'll be honest, i'm a little concerned that:

  1. the superset-ui-demo has its own lockfile even though it's in a monorepo
  2. This added 45k lines to said lockfile

but if you double check and this is all as expected, lgtm!

@rusackas rusackas force-pushed the updating-typescript-to-4.5.4 branch from 4618e53 to 18c901a Compare January 9, 2022 07:19
@rusackas rusackas force-pushed the updating-typescript-to-4.5.4 branch from 18c901a to 9d5dbcb Compare January 9, 2022 17:09
@rusackas
Copy link
Member Author

Thanks for the review @etr2460 - that package lock was accidental, and I'm glad you stopped to notice the gigantic file.

@rusackas rusackas merged commit c0a7695 into master Jan 10, 2022
@rusackas rusackas deleted the updating-typescript-to-4.5.4 branch January 10, 2022 04:02
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
…17971)

* chore: bump typescript to 4.5.4, and adjust storybook story to pass linting

* ugh... missed a space. Thanks, linter :)

* nixing erroneous package lock file
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
…17971)

* chore: bump typescript to 4.5.4, and adjust storybook story to pass linting

* ugh... missed a space. Thanks, linter :)

* nixing erroneous package lock file
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants