Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dashboard permission #1806

Closed
wants to merge 1 commit into from
Closed

add dashboard permission #1806

wants to merge 1 commit into from

Conversation

ujhujuh
Copy link

@ujhujuh ujhujuh commented Dec 9, 2016

grant permission to each dashboard manually.

@mistercrunch
Copy link
Member

mistercrunch commented Dec 12, 2016

This has some complex-ish implications and we need to discuss internally whether we want to add this new dimension in the security matrix. For instance what happens now if the person has access to the dashboard but not to the underlying table(s)? What happens to permissions when someone renames a dashboard?

@xrmx
Copy link
Contributor

xrmx commented Dec 12, 2016

@mistercrunch it would fail, which is backward compatible with current permissions.
The only annoying and incompatible change is that with the patch one that has access to a datasource has no more automatic access to dashboards that use that datasource.
Good catch on dashboard renaming though, that'll would be a problem.

@acorso522
Copy link

Any updates on this front? The ability to restrict users to only specific dashboards is extremely useful.

@yamyamyuo
Copy link
Contributor

Authorization based on datasource is more complicated when more users in superset. Think about this scenario. It is more convenient for superset admins to grant marketing dashboards permissions to marketing team members.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants