Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate QueryAndSaveBtns to TypeScript and add stories #18121

Merged
merged 2 commits into from
Feb 15, 2022

Conversation

ad-m
Copy link
Contributor

@ad-m ad-m commented Jan 20, 2022

SUMMARY

Migrated QueryAndSaveBtns to TypeScript to apply direction outlined in #18100 .

In addition, added a new story to visualize that component.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

obraz

TESTING INSTRUCTIONS

Storybook can be used to verify that changes.

ADDITIONAL INFORMATION

  • Has associated issue: see Migrate components to TypeScript #18100
  • Required feature flags: no
  • Changes UI: no
  • Includes DB Migration (follow approval process in SIP-59): no
    • Migration is atomic, supports rollback & is backwards-compatible: N/A
    • Confirm DB migration upgrade and downgrade tested: N/A
    • Runtime estimates and downtime expectations provided: N/A
  • Introduces new feature or API: no
  • Removes existing feature or API: no

@kgabryje , @asadUllah58 You might be interested in this PR!

@ad-m ad-m changed the title refactor: Migrate QueryAndSaveBtns to TS and stories refactor: Migrate QueryAndSaveBtns to TypeScript and add stories Jan 20, 2022
@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #18121 (f27e529) into master (959b15e) will decrease coverage by 0.00%.
The diff coverage is 80.00%.

❗ Current head f27e529 differs from pull request most recent head d597980. Consider uploading reports for the commit d597980 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18121      +/-   ##
==========================================
- Coverage   65.97%   65.97%   -0.01%     
==========================================
  Files        1584     1584              
  Lines       62003    62003              
  Branches     6243     6243              
==========================================
- Hits        40905    40904       -1     
- Misses      19497    19498       +1     
  Partials     1601     1601              
Flag Coverage Δ
javascript 50.90% <80.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Button/index.tsx 100.00% <ø> (ø)
...rontend/src/explore/components/EmbedCodeButton.jsx 78.94% <ø> (ø)
...ontend/src/explore/components/QueryAndSaveBtns.tsx 42.85% <80.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 959b15e...d597980. Read the comment docs.

@ad-m ad-m changed the title refactor: Migrate QueryAndSaveBtns to TypeScript and add stories refactor: migrate QueryAndSaveBtns to TypeScript and add stories Jan 20, 2022
@ad-m ad-m closed this Jan 21, 2022
@ad-m ad-m reopened this Jan 21, 2022
@ad-m ad-m closed this Jan 21, 2022
@ad-m ad-m reopened this Jan 21, 2022
@ad-m ad-m closed this Jan 25, 2022
@ad-m ad-m reopened this Jan 25, 2022
@ad-m
Copy link
Contributor Author

ad-m commented Jan 25, 2022

@kgabryje , CI finally fixed. Could you take a look?

@ad-m ad-m requested a review from kgabryje January 28, 2022 17:39
@geido
Copy link
Member

geido commented Feb 11, 2022

/testenv up

@github-actions
Copy link
Contributor

@geido Ephemeral environment spinning up at http://54.212.112.30:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@geido geido merged commit 8b3e27d into apache:master Feb 15, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants