-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate QueryAndSaveBtns to TypeScript and add stories #18121
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18121 +/- ##
==========================================
- Coverage 65.97% 65.97% -0.01%
==========================================
Files 1584 1584
Lines 62003 62003
Branches 6243 6243
==========================================
- Hits 40905 40904 -1
- Misses 19497 19498 +1
Partials 1601 1601
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@kgabryje , CI finally fixed. Could you take a look? |
/testenv up |
@geido Ephemeral environment spinning up at http://54.212.112.30:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Migrated QueryAndSaveBtns to TypeScript to apply direction outlined in #18100 .
In addition, added a new story to visualize that component.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Storybook can be used to verify that changes.
ADDITIONAL INFORMATION
@kgabryje , @asadUllah58 You might be interested in this PR!