-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove redundant propTypes in ColumnElement #18144
Conversation
superset-frontend/src/SqlLab/components/ColumnElement/index.tsx
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #18144 +/- ##
==========================================
- Coverage 65.95% 65.92% -0.03%
==========================================
Files 1584 1587 +3
Lines 62046 62116 +70
Branches 6273 6287 +14
==========================================
+ Hits 40920 40950 +30
- Misses 19505 19544 +39
- Partials 1621 1622 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Just started the CI. I'll keep an eye |
Can also test 18141, 18142, 18143 PR? |
@lyndsiWilliams @AAfghahi Can you merge the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got just one question, otherwise this looks good 😁
superset-frontend/src/SqlLab/components/ColumnElement/index.tsx
Outdated
Show resolved
Hide resolved
We can review and approve PRs, but we can't merge unless there's also an approval from a higher-level engineer. |
@lyndsiWilliams Got it, can you review it again? |
The code looks good! Could you fill in the description of your PR? |
Sure, done |
* Remove redundant propTypes * Refactoring * Refactoring
SUMMARY
Refactoring ColumnElement component and remove redundant propTypes code
ADDITIONAL INFORMATION