Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move controlPanel into time_table #18160

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

zhaoyongjie
Copy link
Member

SUMMARY

Move control panel into time_table's directory

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #18160 (611539b) into master (4b89ac7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18160      +/-   ##
==========================================
- Coverage   65.95%   65.95%   -0.01%     
==========================================
  Files        1584     1584              
  Lines       62046    62054       +8     
  Branches     6273     6273              
==========================================
+ Hits        40920    40925       +5     
- Misses      19505    19508       +3     
  Partials     1621     1621              
Flag Coverage Δ
javascript 50.88% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...set-frontend/src/visualizations/TimeTable/index.ts 66.66% <ø> (ø)
...-frontend/src/visualizations/presets/MainPreset.js 100.00% <ø> (ø)
superset-frontend/src/setup/setupPlugins.ts 100.00% <100.00%> (ø)
...nd/src/explore/components/ExploreActionButtons.tsx 59.45% <0.00%> (-3.40%) ⬇️
...ews/CRUD/annotationlayers/AnnotationLayerModal.tsx 58.97% <0.00%> (-1.56%) ⬇️
...src/dashboard/components/PropertiesModal/index.tsx 64.33% <0.00%> (+0.25%) ⬆️
...dashboard/components/SliceHeaderControls/index.tsx 66.66% <0.00%> (+0.41%) ⬆️
.../components/Header/HeaderActionsDropdown/index.jsx 71.92% <0.00%> (+0.50%) ⬆️
...d/src/explore/components/PropertiesModal/index.tsx 68.33% <0.00%> (+0.53%) ⬆️
.../src/dashboard/components/RefreshIntervalModal.tsx 80.00% <0.00%> (+0.83%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b89ac7...611539b. Read the comment docs.

@rusackas
Copy link
Member

/testenv up

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Just spinning up an ephemeral env to test now.

@github-actions
Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://54.244.146.30:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@zhaoyongjie zhaoyongjie merged commit ea2d668 into apache:master Jan 28, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
ofekisr pushed a commit to nielsen-oss/superset that referenced this pull request Feb 8, 2022
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants