refactor: converted QueryAutoRefresh to functional component #18179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AAfghahi
added
the
Superset-Community-Partners
briannguyen4
force-pushed
the
brian-nguyen/QueryAutoRefreshConversion
branch
3 times, most recently
from
cb42dd5
to
68c26bb
Compare
briannguyen4
force-pushed
the
brian-nguyen/QueryAutoRefreshConversion
branch
from
68c26bb
to
8694429
Compare
ad-m
reviewed
Jan 27, 2022
superset-frontend/src/SqlLab/components/QueryAutoRefresh/index.jsx
Outdated
Show resolved
Hide resolved
briannguyen4
force-pushed
the
brian-nguyen/QueryAutoRefreshConversion
branch
from
48cc869
to
2a09ab7
Compare
lyndsiWilliams
approved these changes
Jan 28, 2022
lyndsiWilliams
changed the title
|
Hey @briannguyen4 thanks for the contribution! It looks like unit tests might require some love for this to pass. |
Codecov Report
@@ Coverage Diff @@
## master #18179 +/- ##
==========================================
- Coverage 66.04% 65.99% -0.05%
==========================================
Files 1591 1620 +29
Lines 62398 62961 +563
Branches 6283 6420 +137
==========================================
+ Hits 41210 41552 +342
- Misses 19567 19747 +180
- Partials 1621 1662 +41
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
AAfghahi
approved these changes
Mar 1, 2022
eschutho
approved these changes
Mar 1, 2022
9 tasks
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 17, 2022
…nent … (apache#19226) * Revert "refactor: converted QueryAutoRefresh to functional component (apache#18179)" This reverts commit f497c19. * lint (cherry picked from commit fc87218)
villebro
pushed a commit
that referenced
this pull request
Apr 3, 2022
* converted file to functional component * refactor: convert class component to functional component * refactor: convert class component to functional" * Working on converting the shouldCheckForQueries test to RTL * Working on converting first test to RTL * Working on first test for queryAutoRefresh * Finished Tests, pushing for review * Cleaned up comments and console logs Co-authored-by: Josue Lugaro <josuelugaro15@gmail.com> (cherry picked from commit f497c19)
villebro
pushed a commit
that referenced
this pull request
Apr 3, 2022
mistercrunch
added
🍒 1.5.0
🍒 1.5.1
🍒 1.5.2
🍒 1.5.3
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Converted QueryAutoRefresh class component into functional component.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Run a query and see if the timer works.
ADDITIONAL INFORMATION