Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Various docstring fixes #18221

Merged
merged 1 commit into from
Mar 21, 2022
Merged

chore: Various docstring fixes #18221

merged 1 commit into from
Mar 21, 2022

Conversation

PApostol
Copy link
Contributor

SUMMARY

Various docstring fixes & improvements.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #18221 (61e773e) into master (c40b337) will decrease coverage by 0.17%.
The diff coverage is n/a.

❗ Current head 61e773e differs from pull request most recent head ccb38ae. Consider uploading reports for the commit ccb38ae to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18221      +/-   ##
==========================================
- Coverage   66.30%   66.13%   -0.18%     
==========================================
  Files        1592     1592              
  Lines       62437    62437              
  Branches     6292     6292              
==========================================
- Hits        41401    41290     -111     
- Misses      19383    19494     +111     
  Partials     1653     1653              
Flag Coverage Δ
hive ?
mysql 81.27% <ø> (ø)
postgres 81.31% <ø> (-0.02%) ⬇️
presto ?
python 81.40% <ø> (-0.37%) ⬇️
sqlite 81.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/utils/mock_data.py 0.00% <ø> (ø)
superset/views/utils.py 82.20% <ø> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.27% <0.00%> (-15.45%) ⬇️
superset/db_engine_specs/presto.py 83.47% <0.00%> (-5.65%) ⬇️
superset/reports/commands/log_prune.py 85.71% <0.00%> (-3.58%) ⬇️
superset/commands/importers/v1/utils.py 89.13% <0.00%> (-2.18%) ⬇️
superset/connectors/sqla/models.py 87.06% <0.00%> (-1.45%) ⬇️
superset/common/query_object.py 95.08% <0.00%> (-0.55%) ⬇️
superset/db_engine_specs/base.py 88.05% <0.00%> (-0.38%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c40b337...ccb38ae. Read the comment docs.

@PApostol PApostol changed the title Various docstring fixes chore: Various docstring fixes Jan 28, 2022
@PApostol
Copy link
Contributor Author

Hi, is anyone able to review this PR?

@PApostol
Copy link
Contributor Author

Hi @villebro, @michael-s-molina, any chance one of you could review this PR?

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fixes!

@michael-s-molina michael-s-molina merged commit c07a707 into apache:master Mar 21, 2022
@PApostol PApostol deleted the docstring-fix branch March 21, 2022 17:50
michael-hoffman-26 pushed a commit to nielsen-oss/superset that referenced this pull request Mar 23, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
(cherry picked from commit c07a707)
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants