Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): migrate mssql tests to pytest #18251

Merged
merged 2 commits into from
Feb 2, 2022

Conversation

villebro
Copy link
Member

@villebro villebro commented Feb 2, 2022

SUMMARY

Migrate MSSQL engine spec tests from integration tests to new pytest-based unit tests, along with parametrizing all tests that were possible. Also clean up the dttm fixture in the Kusto spec.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #18251 (1e43f62) into master (8c37654) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18251   +/-   ##
=======================================
  Coverage   66.32%   66.32%           
=======================================
  Files        1592     1592           
  Lines       62569    62569           
  Branches     6295     6295           
=======================================
  Hits        41500    41500           
  Misses      19416    19416           
  Partials     1653     1653           
Flag Coverage Δ
hive 52.13% <ø> (ø)
mysql 81.25% <ø> (ø)
postgres 81.29% <ø> (ø)
presto 51.97% <ø> (ø)
python 81.73% <ø> (ø)
sqlite 80.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c37654...1e43f62. Read the comment docs.

@villebro villebro merged commit 7ad38d5 into apache:master Feb 2, 2022
@villebro villebro deleted the villebro/migrate-mssql-pytest branch February 2, 2022 11:24
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
ofekisr pushed a commit to nielsen-oss/superset that referenced this pull request Feb 8, 2022
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XL 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants