fix: sqllab schema select error msg #18564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkdotson
requested review from
betodealmeida,
eschutho,
yousoph,
hughhhh and
lyndsiWilliams
villebro
reviewed
Feb 3, 2022
Codecov Report
@@ Coverage Diff @@
## master #18564 +/- ##
==========================================
+ Coverage 66.27% 66.29% +0.01%
==========================================
Files 1594 1594
Lines 62621 62623 +2
Branches 6311 6312 +1
==========================================
+ Hits 41505 41518 +13
+ Misses 19467 19456 -11
Partials 1649 1649
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
9 tasks
lyndsiWilliams
approved these changes
Feb 4, 2022
|
🏷 preset:2022.5 |
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Feb 7, 2022
* fix: sqllab schema select error msg * remove console logs * fix lint (cherry picked from commit 151d30b)
shcoderAlex
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 7, 2022
* fix: sqllab schema select error msg * remove console logs * fix lint
ofekisr
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Feb 8, 2022
* fix: sqllab schema select error msg * remove console logs * fix lint
bwang221
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 10, 2022
* fix: sqllab schema select error msg * remove console logs * fix lint
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This pr fixes and issue where if the sqllab backend persistence flag is on the param being passed into the dispatch function is not always a object and will subsequently caused the call to fail.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
after
Screen.Recording.2022-02-02.at.9.29.30.PM.mov
TESTING INSTRUCTIONS
Go to sql lab and click the schema and database selects. The error toast should not show.
ADDITIONAL INFORMATION