chore: upgrading cypress to version 9

[sadpandajoe]

SUMMARY

Upgrading cypress to the latest version following their (migration guide)[https://docs.cypress.io/guides/references/migration-guide#Migrating-from-cypress-file-upload-to-selectFile].

• Bumping version to 9
• Removing flag --headless as it's default with Cypress 8
• No other test updates are required as part of the migration

Here is the change log of all the changes made.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

• Run all tests to ensure they are passing

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #18606 (468a34a) into master (5f3e73c) will decrease coverage by 0.40%.
The diff coverage is n/a.

❗ Current head 468a34a differs from pull request most recent head 243e4f0. Consider uploading reports for the commit 243e4f0 to get more accurate results

@@            Coverage Diff             @@
##           master   #18606      +/-   ##
==========================================
- Coverage   66.52%   66.12%   -0.41%     
==========================================
  Files        1714     1624      -90     
  Lines       65046    63149    -1897     
  Branches     6722     6505     -217     
==========================================
- Hits        43274    41755    -1519     
+ Misses      20060    19711     -349     
+ Partials     1712     1683      -29     

Flag	Coverage Δ
javascript	51.33% <ø> (+0.08%)	⬆️
unit	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...in-chart-echarts/src/MixedTimeseries/buildQuery.ts	0.00% <0.00%> (-100.00%)	⬇️
superset/db_engine_specs/__init__.py	46.15% <0.00%> (-38.47%)	⬇️
superset/migrations/shared/utils.py	0.00% <0.00%> (-36.18%)	⬇️
superset/connectors/sqla/views.py	64.01% <0.00%> (-27.04%)	⬇️
...perset-frontend/src/explore/components/Control.tsx	53.84% <0.00%> (-17.59%)	⬇️
...uperset-frontend/src/explore/exploreUtils/index.js	63.90% <0.00%> (-17.12%)	⬇️
...rontend/src/components/Select/DeprecatedSelect.tsx	37.33% <0.00%> (-16.00%)	⬇️
...-frontend/src/components/CronPicker/CronPicker.tsx	85.71% <0.00%> (-14.29%)	⬇️
superset-frontend/src/components/Select/styles.tsx	67.92% <0.00%> (-13.21%)	⬇️
...chart-echarts/src/MixedTimeseries/controlPanel.tsx	80.00% <0.00%> (-12.86%)	⬇️
... and 516 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f3e73c...243e4f0. Read the comment docs.

[zhaoyongjie]

@sadpandajoe Could you rebase the latest master to your branch? Thanks!

[sadpandajoe]

@zhaoyongjie done.

[zhaoyongjie]

@sadpandajoe, thanks!
The CI is blocked by an npm compatible error. I think we just need to remove the engines declaration to fix it.

diff --git a/superset-frontend/tools/eslint-plugin-translation-vars/package.json b/superset-frontend/tools/eslint-plugin-translation-vars/package.json
index d4353a88d..83e8c184d 100644
--- a/superset-frontend/tools/eslint-plugin-translation-vars/package.json
+++ b/superset-frontend/tools/eslint-plugin-translation-vars/package.json
@@ -12,9 +12,5 @@
   "dependencies": {},
   "peerDependencies": {
     "eslint": ">=0.8.0"
-  },
-  "engines": {
-    "node": "^16.9.1",
-    "npm": "^7.5.4"
   }
 }

[sadpandajoe]

@zhaoyongjie this was added by @stephenLYZ in this PR: https://github.com/apache/superset/pull/19828/files. I want to confirm that it's ok with them before editing that file as I don't want to break other things.

[zhaoyongjie]

@stephenLYZ Could you confirm that this modification is safe?

[sadpandajoe]

closing for now

[rusackas]

@sadpandajoe looks like you intended to close this. I'll do ya the favor, but please feel free to reopen if warranted.