Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check embedded feature flag in request loader #18628

Merged
merged 3 commits into from
Feb 9, 2022

Conversation

lilykuang
Copy link
Member

SUMMARY

  • move the feature flag check to request loader

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #18628 (e508457) into master (51f716f) will increase coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18628   +/-   ##
=======================================
  Coverage   66.31%   66.31%           
=======================================
  Files        1595     1595           
  Lines       62596    62599    +3     
  Branches     6297     6297           
=======================================
+ Hits        41510    41513    +3     
  Misses      19440    19440           
  Partials     1646     1646           
Flag Coverage Δ
hive 52.14% <83.33%> (+<0.01%) ⬆️
javascript 51.33% <ø> (ø)
mysql 81.26% <83.33%> (+<0.01%) ⬆️
postgres 81.31% <83.33%> (+<0.01%) ⬆️
presto 51.98% <83.33%> (+<0.01%) ⬆️
python 81.75% <83.33%> (+<0.01%) ⬆️
sqlite 81.01% <83.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/security/manager.py 92.30% <83.33%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51f716f...e508457. Read the comment docs.

@lilykuang lilykuang merged commit e86f6bb into master Feb 9, 2022
@lilykuang lilykuang deleted the embedded-get-guest-user-from-request branch February 9, 2022 04:14
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants