fix(hive): stop query on the processing engine when user clicks STOP on SQL Lab

[saurabh3091]

This addressed 18787
The issue concerns hive/spark-thriftserver as the processing engine.
When a user runs a query on SQL Lab and later for any reason wants to stop it, it doesn't stop it on the hive/spark query engine.

SUMMARY

While debugging we figured that the state updated at core.py is not reflected at the logic for canceling the job.

So we have added a small fix to update the session before it checks for the STOPPED status.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After

TESTING INSTRUCTIONS

1. Run any query in SQL Lab with hive/spark-thriftserver as backend processing engine.
2. Press STOP button on the UI.
3. Check the query engine, the query will be stopped both on the frontend and backend.

ADDITIONAL INFORMATION

Fixes #18787

• Has associated issue: 18787
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #18789 (5805fb3) into master (f5f25ff) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #18789   +/-   ##
=======================================
  Coverage   66.32%   66.32%           
=======================================
  Files        1620     1620           
  Lines       63087    63088    +1     
  Branches     6372     6372           
=======================================
+ Hits        41840    41841    +1     
  Misses      19590    19590           
  Partials     1657     1657           

Flag	Coverage Δ
hive	52.22% <100.00%> (+<0.01%)	⬆️
mysql	81.42% <0.00%> (-0.01%)	⬇️
postgres	81.47% <0.00%> (-0.01%)	⬇️
presto	52.06% <0.00%> (-0.01%)	⬇️
python	81.90% <100.00%> (+<0.01%)	⬆️
sqlite	81.16% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/db_engine_specs/hive.py	85.76% <100.00%> (+0.05%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5f25ff...5805fb3. Read the comment docs.

[villebro]

LGTM, thanks for the fix!