-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds support to multiple dependencies to the native filters #18793
feat: Adds support to multiple dependencies to the native filters #18793
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18793 +/- ##
==========================================
- Coverage 66.56% 66.52% -0.05%
==========================================
Files 1641 1641
Lines 63495 63468 -27
Branches 6425 6441 +16
==========================================
- Hits 42265 42221 -44
- Misses 19550 19584 +34
+ Partials 1680 1663 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
...c/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/DependencyList.tsx
Outdated
Show resolved
Hide resolved
...c/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/DependencyList.tsx
Outdated
Show resolved
Hide resolved
...ontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.test.tsx
Outdated
Show resolved
Hide resolved
c00753e
to
c6294b0
Compare
c6294b0
to
7640f27
Compare
...c/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/DependencyList.tsx
Show resolved
Hide resolved
...c/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/DependencyList.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/utils.ts
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/utils.ts
Outdated
Show resolved
Hide resolved
0f526c0
to
cf7774d
Compare
...et-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx
Outdated
Show resolved
Hide resolved
545ca32
to
5f4da63
Compare
e63f4a2
to
f80618b
Compare
796d7d3
to
493ea96
Compare
Ephemeral environment shutdown and build artifacts deleted. |
…8793) * chore(native-filters): Remove cascading popovers from filter bar Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
SUMMARY
Adds support to multiple dependencies to the native filters. This will allow the user to create hierarchical and graph relationships among filters. The changes are the result of a series of interviews conducted by the design team with Superset users. Here's a summary of the changes:
It's important to note that major refactors are not in the scope at this stage. Our first objective is to deprecate FilterBox. We'll tackle code improvements in the next stage of the native filters revamp.
@kasiazjc @jess-dillard
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2022-02-24.at.1.43.48.PM.mov
TESTING INSTRUCTIONS
We need to test the whole module. Apart from the basic tests, some important behaviors that should be checked:
ADDITIONAL INFORMATION