Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(readme): Adding pinot logo into Readme Supported Databases Section #18798

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Feb 17, 2022

SUMMARY

Adding pinot logo into Readme Supported Databases Section

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

You can preview it from here:
https://github.com/xiangfu0/superset/tree/pinot-logo#supported-databases

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@xiangfu0 xiangfu0 changed the title Adding pinot logo into Readme Supported Databases Section docs: Adding pinot logo into Readme Supported Databases Section Feb 17, 2022
@xiangfu0 xiangfu0 closed this Feb 17, 2022
@xiangfu0 xiangfu0 reopened this Feb 17, 2022
@xiangfu0 xiangfu0 closed this Feb 17, 2022
@xiangfu0 xiangfu0 reopened this Feb 17, 2022
@xiangfu0 xiangfu0 changed the title docs: Adding pinot logo into Readme Supported Databases Section chore(readme): Adding pinot logo into Readme Supported Databases Section Feb 17, 2022
@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #18798 (b9b2eec) into master (2d67d2f) will increase coverage by 0.02%.
The diff coverage is 60.00%.

❗ Current head b9b2eec differs from pull request most recent head 23cd335. Consider uploading reports for the commit 23cd335 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18798      +/-   ##
==========================================
+ Coverage   66.32%   66.34%   +0.02%     
==========================================
  Files        1620     1620              
  Lines       63087    63088       +1     
  Branches     6372     6372              
==========================================
+ Hits        41840    41857      +17     
+ Misses      19590    19570      -20     
- Partials     1657     1661       +4     
Flag Coverage Δ
javascript 51.30% <33.33%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/SqlLab/components/ResultSet/index.tsx 50.73% <ø> (ø)
...lLab/components/ExploreCtasResultsButton/index.tsx 8.33% <33.33%> (ø)
superset/reports/notifications/slack.py 87.67% <100.00%> (+0.34%) ⬆️
...board/components/nativeFilters/FilterBar/index.tsx 80.17% <0.00%> (+10.34%) ⬆️
...rd/components/nativeFilters/FilterBar/keyValue.tsx 45.45% <0.00%> (+27.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d67d2f...23cd335. Read the comment docs.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaoyongjie zhaoyongjie merged commit ea9a904 into apache:master Feb 18, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants