Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(pinot): Update pinot docs with fixed pinot connection #18800

Merged
merged 1 commit into from
Feb 18, 2022
Merged

docs(pinot): Update pinot docs with fixed pinot connection #18800

merged 1 commit into from
Feb 18, 2022

Conversation

xiangfu0
Copy link
Contributor

SUMMARY

doc: Update pinot docs with fixed pinot connection

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@xiangfu0 xiangfu0 changed the title doc(pinot): Update pinot docs with fixed pinot connection docs(pinot): Update pinot docs with fixed pinot connection Feb 18, 2022
@xiangfu0 xiangfu0 closed this Feb 18, 2022
@xiangfu0 xiangfu0 reopened this Feb 18, 2022
zhaoyongjie
zhaoyongjie approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

align with pypi, LGTM!

@zhaoyongjie zhaoyongjie merged commit 642e80c into apache:master Feb 18, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaoyongjie zhaoyongjie zhaoyongjie approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiangfu0 @zhaoyongjie @mistercrunch