Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Null schema issue in the list of saved queries. #18849

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

codemaster08240328
Copy link
Contributor

SUMMARY

Database schema is displayed as null in the list of saved queries.
It should be displayed according to the schema selected in sql editor.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE & AFTER updates:
image

TESTING INSTRUCTIONS

  1. Go to SQL Editor
  2. Run any query and save it
  3. Go to the Saved Queries page
  4. Check the database schema of newly saved query.

@codemaster08240328
Copy link
Contributor Author

/testenv up

@github-actions
Copy link
Contributor

@codemaster08240328 Ephemeral environment creation is currently limited to committers.

@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #18849 (b750ad7) into master (4c16586) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18849      +/-   ##
==========================================
- Coverage   66.36%   66.36%   -0.01%     
==========================================
  Files        1620     1621       +1     
  Lines       63045    63059      +14     
  Branches     6377     6382       +5     
==========================================
+ Hits        41842    41848       +6     
- Misses      19544    19549       +5     
- Partials     1659     1662       +3     
Flag Coverage Δ
javascript 51.24% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/src/SqlLab/components/SqlEditorLeftBar/index.tsx 56.66% <50.00%> (-0.48%) ⬇️
...board/components/nativeFilters/FilterBar/index.tsx 66.94% <0.00%> (-2.88%) ⬇️
...d/components/DashboardBuilder/DashboardBuilder.tsx 72.72% <0.00%> (-2.57%) ⬇️
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 77.57% <0.00%> (-1.82%) ⬇️
superset-frontend/src/dashboard/constants.ts 100.00% <0.00%> (ø)
superset-frontend/src/components/Button/index.tsx 100.00% <0.00%> (ø)
...ts/nativeFilters/FilterBar/ActionButtons/index.tsx 85.71% <0.00%> (ø)
superset-frontend/src/utils/common.js 89.47% <0.00%> (+0.18%) ⬆️
...ilters/FilterBar/FilterControls/FilterControls.tsx 77.77% <0.00%> (+0.63%) ⬆️
...nents/nativeFilters/FilterBar/FilterSets/index.tsx 37.66% <0.00%> (+0.82%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c16586...b750ad7. Read the comment docs.

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks for the fix!

@kgabryje kgabryje merged commit 79633ce into apache:master Feb 25, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants