Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add GA conf to config #18861

Merged
merged 2 commits into from
Feb 23, 2022
Merged

Conversation

villebro
Copy link
Member

@villebro villebro commented Feb 23, 2022

SUMMARY

A recent migration of the docs site to Docusaurus in #17411 lost Google Analytics tracking. Here we add the same GA confs that were introduced in #11613 by leveraging the plugin-google-analytics plugin that's included in the preset-classic that's already in use. In addition, Docusaurus is bumped to the latest version as the configuration mechanism changed recently (see facebook/docusaurus#5832 which was included in the 2.0.0-beta.10 release). A missing license property is added to the package.json file of the docs package.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

The site looks the same as before:
image

TESTING INSTRUCTIONS

Make sure the docs site builds correctly and looks correct when run locally:

  1. cd docs
  2. yarn install
  3. yarn build
  4. yarn start

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@villebro villebro merged commit 700829b into apache:master Feb 23, 2022
@villebro villebro deleted the villebro/docusaurus-ga branch February 23, 2022 08:34
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XXL 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants