fix: Source from Apache Foundation's website link #18894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes a link to latest version on Download the source from Apache Foundation's website link from : https://dist.apache.org/repos/dist/release/superset/1.0.0/ to: https://dist.apache.org/repos/dist/release/superset/1.4.1/
srinify
requested changes
Feb 23, 2022
| @@ -13,7 +13,7 @@ geospatial charts. | |||
|
|
|||
| Here are a **few different ways you can get started with Superset**: | |||
|
|
|||
| - Download the [source from Apache Foundation's website](https://dist.apache.org/repos/dist/release/superset/1.0.0/) | |||
| - Download the [source from Apache Foundation's website](https://dist.apache.org/repos/dist/release/superset/1.4.1/) | |||
There was a problem hiding this comment.
I wonder if we should just link to https://dist.apache.org/repos/dist/release/superset/ instead? That way we don't have to keep remembering to update it each time / people can choose the version they want etc.
There was a problem hiding this comment.
I think if have a latest version should be a better way, for new downloads I don't know if oldest version would matter
srinify
approved these changes
Feb 23, 2022
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a link to latest version on Download the source from Apache Foundation's website link
from : https://dist.apache.org/repos/dist/release/superset/1.0.0/
to: https://dist.apache.org/repos/dist/release/superset/1.4.1/
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION